From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
To: Avi Kivity <avi@redhat.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: Re: [PATCH] lance: unbreak after memory API conversion
Date: Tue, 9 Aug 2011 09:01:21 +0200 [thread overview]
Message-ID: <20110809070121.GC3730@zapo> (raw)
In-Reply-To: <1312872862-30933-1-git-send-email-avi@redhat.com>
On Tue, Aug 09, 2011 at 09:54:22AM +0300, Avi Kivity wrote:
> The conversion passed the wrong opaque pointer, causing a crash on first use.
> Pass the correct opaque.
I've applied this, thanks.
>
> Signed-off-by: Avi Kivity <avi@redhat.com>
> ---
> hw/lance.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hw/lance.c b/hw/lance.c
> index 8e20360..d83e7f5 100644
> --- a/hw/lance.c
> +++ b/hw/lance.c
> @@ -116,7 +116,7 @@ static int lance_init(SysBusDevice *dev)
> SysBusPCNetState *d = FROM_SYSBUS(SysBusPCNetState, dev);
> PCNetState *s = &d->state;
>
> - memory_region_init_io(&s->mmio, &lance_mem_ops, s, "lance-mmio", 4);
> + memory_region_init_io(&s->mmio, &lance_mem_ops, d, "lance-mmio", 4);
>
> qdev_init_gpio_in(&dev->qdev, parent_lance_reset, 1);
>
> --
> 1.7.5.3
>
>
prev parent reply other threads:[~2011-08-09 7:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-09 6:54 [PATCH] lance: unbreak after memory API conversion Avi Kivity
2011-08-09 7:01 ` Edgar E. Iglesias [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110809070121.GC3730@zapo \
--to=edgar.iglesias@gmail.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).