From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Subject: Re: [PATCH] lance: unbreak after memory API conversion
Date: Tue, 9 Aug 2011 09:01:21 +0200
Message-ID: <20110809070121.GC3730@zapo>
References: <1312872862-30933-1-git-send-email-avi@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org
To: Avi Kivity <avi@redhat.com>
Return-path: <qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org>
Content-Disposition: inline
In-Reply-To: <1312872862-30933-1-git-send-email-avi@redhat.com>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: </archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org
Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org
List-Id: kvm.vger.kernel.org

On Tue, Aug 09, 2011 at 09:54:22AM +0300, Avi Kivity wrote:
> The conversion passed the wrong opaque pointer, causing a crash on first use.
> Pass the correct opaque.

I've applied this, thanks.


> 
> Signed-off-by: Avi Kivity <avi@redhat.com>
> ---
>  hw/lance.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/hw/lance.c b/hw/lance.c
> index 8e20360..d83e7f5 100644
> --- a/hw/lance.c
> +++ b/hw/lance.c
> @@ -116,7 +116,7 @@ static int lance_init(SysBusDevice *dev)
>      SysBusPCNetState *d = FROM_SYSBUS(SysBusPCNetState, dev);
>      PCNetState *s = &d->state;
>  
> -    memory_region_init_io(&s->mmio, &lance_mem_ops, s, "lance-mmio", 4);
> +    memory_region_init_io(&s->mmio, &lance_mem_ops, d, "lance-mmio", 4);
>  
>      qdev_init_gpio_in(&dev->qdev, parent_lance_reset, 1);
>  
> -- 
> 1.7.5.3
> 
>