From: "David Evensky" <evensky@dancer.ca.sandia.gov>
To: "Pekka Enberg" <penberg@kernel.org>
Cc: "Avi Kivity" <avi@redhat.com>, "Ingo Molnar" <mingo@elte.hu>,
"Sasha Levin" <levinsasha928@gmail.com>,
asias.hejun@gmail.com, prasadjoshi124@gmail.com,
gorcunov@gmail.com, kvm@vger.kernel.org
Subject: Re: [PATCH] kvm tools: Use correct size for VESA memory BAR
Date: Wed, 10 Aug 2011 10:46:09 -0700 [thread overview]
Message-ID: <20110810174609.GA3663@dancer.ca.sandia.gov> (raw)
In-Reply-To: <4E42218F.4050705@kernel.org>
I don't know if there were any other drivers for this patch, but it
along with another patch (maybe integrated elsewhere for 32bit BAR vs
8bit) certainly helped me out a lot. These patches fixed ioremap
errors I was seeing (I had a 16MB PCI memory region, but it appeared
to be only 256 bytes in size; the kernel complained bitterly about
that on ioremap). It also was an issue of expected vs unexpected
output from lspci -vvv.
I'm working on my out-of-tree PCI driver to see if it can become in
tree. I have more cleanup to do, and seeing how close I can come to
the target coding standards.
\dae
On Wed, Aug 10, 2011 at 09:13:35AM +0300, Pekka Enberg wrote:
> On 8/9/11 7:46 PM, Avi Kivity wrote:
> >On 08/09/2011 06:39 PM, Ingo Molnar wrote:
> >>* Sasha Levin<levinsasha928@gmail.com> wrote:
> >>
> >>> This patch makes BAR 1 16k, instead of BAR0 - which is the PIO bar.
> >>>
> >>
> >>This changelog is missing some key information:
> >>
> >> - how did you find the bug (by chance via code review or did you see
> >> some actual badness?)
> >>
> >> - what practical effect (if any) did you see from this patch?
> >>
> >> - what practical effect (if any) do you expect others to see
> >>from this patch?
> >>
> >>I suspect this patch is only for completeness/correctness but has no
> >>practical effect - but that's a guess.
> >>
> >
> >My guess would be that seabios tried to lay out the BARs and had
> >trouble fitting a 16k pio bar in the small PCI pio region.
>
> Sasha? IIRC this fixed some issue with David's out-of-tree PCI driver?
next prev parent reply other threads:[~2011-08-10 17:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-09 15:21 [PATCH] kvm tools: Use correct size for VESA memory BAR Sasha Levin
2011-08-09 15:39 ` Ingo Molnar
2011-08-09 16:46 ` Avi Kivity
2011-08-10 6:13 ` Pekka Enberg
2011-08-10 17:46 ` David Evensky [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-08-11 9:04 [PATCH] kvm tools: Fix IRQ mapping Sasha Levin
2011-08-11 9:04 ` [PATCH] kvm tools: Use correct size for VESA memory bar Sasha Levin
2011-08-11 9:49 ` walimis
2011-08-11 11:55 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110810174609.GA3663@dancer.ca.sandia.gov \
--to=evensky@dancer.ca.sandia.gov \
--cc=asias.hejun@gmail.com \
--cc=avi@redhat.com \
--cc=gorcunov@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=levinsasha928@gmail.com \
--cc=mingo@elte.hu \
--cc=penberg@kernel.org \
--cc=prasadjoshi124@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox