From mboxrd@z Thu Jan 1 00:00:00 1970 From: walimis Subject: Re: [PATCH 1/3] kvm tools: add signal placeholder to avoid balloon crash Date: Thu, 11 Aug 2011 15:21:42 +0800 Message-ID: <20110811072142.GC13190@walimis-desktop> References: <1313039267-25951-1-git-send-email-walimisdev@gmail.com> <1313047745.3456.4.camel@lappy> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Pekka Enberg , Ingo Molnar , Asias He , kvm@vger.kernel.org To: Sasha Levin Return-path: Received: from mail-ww0-f44.google.com ([74.125.82.44]:60774 "EHLO mail-ww0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751121Ab1HKHhu (ORCPT ); Thu, 11 Aug 2011 03:37:50 -0400 Received: by wwf5 with SMTP id 5so1762602wwf.1 for ; Thu, 11 Aug 2011 00:37:49 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1313047745.3456.4.camel@lappy> Sender: kvm-owner@vger.kernel.org List-ID: On Thu, Aug 11, 2011 at 10:29:05AM +0300, Sasha Levin wrote: >On Thu, 2011-08-11 at 13:07 +0800, Liming Wang wrote: >> If "kvm run" without balloon option, use "kvm balloon" may >> crash kvm. Add signal placeholder to avoid this. >> >> Signed-off-by: Liming Wang >> --- >> tools/kvm/builtin-run.c | 7 +++++++ >> 1 files changed, 7 insertions(+), 0 deletions(-) >> >> diff --git a/tools/kvm/builtin-run.c b/tools/kvm/builtin-run.c >> index fa5de27..d725834 100644 >> --- a/tools/kvm/builtin-run.c >> +++ b/tools/kvm/builtin-run.c >> @@ -280,6 +280,10 @@ static void handle_sigstop(int sig) >> kvm_cpu__reboot(); >> } >> >> +static void handle_empty(int sig) >> +{ >> +} >> + >> static void *kvm_cpu_thread(void *arg) >> { >> current_kvm_cpu = arg; >> @@ -469,6 +473,9 @@ int kvm_cmd_run(int argc, const char **argv, const char *prefix) >> signal(SIGUSR2, handle_sigusr2); >> signal(SIGKVMSTOP, handle_sigstop); >> signal(SIGKVMRESUME, handle_sigusr2); >> + /* signal placeholder if not enable balloon */ >> + signal(SIGKVMADDMEM, handle_empty); > >You can just do this: > signal(SIGKVMADDMEM, SIG_IGN); > >For both, and avoid the empty handler. good. New patch will be sent. walimis > >> + signal(SIGKVMDELMEM, handle_empty); >> >> nr_online_cpus = sysconf(_SC_NPROCESSORS_ONLN); >> > >-- > >Sasha. >