From mboxrd@z Thu Jan 1 00:00:00 1970 From: walimis Subject: Re: [PATCH 1/7] kvm tools: Print version when running 'kvm --version' Date: Fri, 12 Aug 2011 23:22:41 +0800 Message-ID: <20110812152240.GA20279@walimis-desktop> References: <1313162460-14397-1-git-send-email-levinsasha928@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: penberg@kernel.org, kvm@vger.kernel.org, mingo@elte.hu, asias.hejun@gmail.com, gorcunov@gmail.com To: Sasha Levin Return-path: Received: from mail-fx0-f46.google.com ([209.85.161.46]:49301 "EHLO mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753720Ab1HLPir (ORCPT ); Fri, 12 Aug 2011 11:38:47 -0400 Received: by fxh19 with SMTP id 19so2381975fxh.19 for ; Fri, 12 Aug 2011 08:38:46 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1313162460-14397-1-git-send-email-levinsasha928@gmail.com> Sender: kvm-owner@vger.kernel.org List-ID: On Fri, Aug 12, 2011 at 06:20:54PM +0300, Sasha Levin wrote: >Signed-off-by: Sasha Levin >--- > tools/kvm/kvm-cmd.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > >diff --git a/tools/kvm/kvm-cmd.c b/tools/kvm/kvm-cmd.c >index e85f22f..3a90d6d 100644 >--- a/tools/kvm/kvm-cmd.c >+++ b/tools/kvm/kvm-cmd.c >@@ -24,6 +24,7 @@ struct cmd_struct kvm_commands[] = { > { "balloon", kvm_cmd_balloon, NULL, 0 }, > { "list", kvm_cmd_list, NULL, 0 }, > { "version", kvm_cmd_version, NULL, 0 }, >+ { "--version", kvm_cmd_version, NULL, 0 }, Although it works, I think it's not good way to implement a option as a command. walimis > { "stop", kvm_cmd_stop, NULL, 0 }, > { "help", kvm_cmd_help, NULL, 0 }, > { "run", kvm_cmd_run, kvm_run_help, 0 }, >-- >1.7.6 > >-- >To unsubscribe from this list: send the line "unsubscribe kvm" in >the body of a message to majordomo@vger.kernel.org >More majordomo info at http://vger.kernel.org/majordomo-info.html