From mboxrd@z Thu Jan  1 00:00:00 1970
From: walimis <walimisdev@gmail.com>
Subject: Re: [PATCH 1/7] kvm tools: Print version when running 'kvm
 --version'
Date: Fri, 12 Aug 2011 23:43:37 +0800
Message-ID: <20110812154337.GB20279@walimis-desktop>
References: <1313162460-14397-1-git-send-email-levinsasha928@gmail.com>
 <20110812152240.GA20279@walimis-desktop>
 <alpine.DEB.2.00.1108121839140.6873@tiger>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Sasha Levin <levinsasha928@gmail.com>, kvm@vger.kernel.org,
	mingo@elte.hu, asias.hejun@gmail.com, gorcunov@gmail.com
To: Pekka Enberg <penberg@kernel.org>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-wy0-f174.google.com ([74.125.82.174]:51476 "EHLO
	mail-wy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751164Ab1HLP7k (ORCPT <rfc822;kvm@vger.kernel.org>);
	Fri, 12 Aug 2011 11:59:40 -0400
Received: by wyg24 with SMTP id 24so2246037wyg.19
        for <kvm@vger.kernel.org>; Fri, 12 Aug 2011 08:59:39 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.00.1108121839140.6873@tiger>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Fri, Aug 12, 2011 at 06:39:46PM +0300, Pekka Enberg wrote:
>On Fri, 12 Aug 2011, walimis wrote:
>>>@@ -24,6 +24,7 @@ struct cmd_struct kvm_commands[] = {
>>>	{ "balloon",	kvm_cmd_balloon,	NULL,         0 },
>>>	{ "list",	kvm_cmd_list,		NULL,         0 },
>>>	{ "version",	kvm_cmd_version,	NULL,         0 },
>>>+	{ "--version",	kvm_cmd_version,	NULL,         0 },
>>Although it works, I think it's not good way to implement a option
>>as a command.
>
>Well, I already merged the patch because the whole series was so
>super-cool. What downsides are there to implementing the alias like
>this?
no downsides, I just consider that a option is preceded 
with "--", but the struct cmd_struct is to describe a command.

walimis
>
>			Pekka