From mboxrd@z Thu Jan 1 00:00:00 1970 From: Neo Jia Subject: Re: [PATCH] kvm tools: Add 'kvm memstat' command Date: Thu, 18 Aug 2011 17:46:54 -0700 Message-ID: <20110819004654.GA28702@gmail.com> References: <1313409222-3910-1-git-send-email-levinsasha928@gmail.com> <4E490964.5060509@kernel.org> <1313409745.27520.9.camel@lappy> <4E490BCA.3050003@kernel.org> <4E49F9AE.9070401@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Pekka Enberg , Sasha Levin , mingo@elte.hu, prasadjoshi124@gmail.com, gorcunov@gmail.com, kvm@vger.kernel.org To: Asias He Return-path: Received: from mail-iy0-f170.google.com ([209.85.210.170]:60478 "EHLO mail-iy0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751890Ab1HSArC (ORCPT ); Thu, 18 Aug 2011 20:47:02 -0400 Received: by iye16 with SMTP id 16so4913588iye.1 for ; Thu, 18 Aug 2011 17:47:00 -0700 (PDT) Content-Disposition: inline In-Reply-To: <4E49F9AE.9070401@gmail.com> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, Aug 16, 2011 at 01:01:34PM +0800, Asias He wrote: > On 08/15/2011 08:06 PM, Pekka Enberg wrote: > > On 8/15/11 3:02 PM, Sasha Levin wrote: > >> On Mon, 2011-08-15 at 14:56 +0300, Pekka Enberg wrote: > >>> On 8/15/11 2:53 PM, Sasha Levin wrote: > >>>> This patch adds 'kvm memstat' command that allows retrieving memory > >>>> statistics out of > >>>> a running guest using the virtio-balloon stats vq interface. > >>>> > >>>> Signed-off-by: Sasha Levin > >>> Shouldn't we just call this "kvm stat"? We can print out all statistics > >>> by default and > >>> add command line options like "--mem" to display individual stats? > >> Do we have any other statistics to print out at the moment? > > > > Not right now but IIRC Asias talked about networking statistics. The > > 'kvm memstat' feels too specific to justify a separate builtin as > > opposed to an command line option in a 'kvm stat' command. > > Yes. the command I am proposing is 'kvm info'. We can have a lot of > thing in 'kvm info', like register info, network info ,disk info. mem > info. Actually, Pekka suggested to have kvm info for all the infos and > if we are getting too much, we can split kvm info into sub command, like > kvm info mem, kvm info reg. Should we already have something similar from QEMU already such as register and memory access? Can we use this interface to write to guest physical address? Thanks, CJ > > -- > Best Regards, > Asias He > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html