From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [PATCH 1/5] Support for vm_stop from the migration thread Date: Mon, 29 Aug 2011 13:56:24 -0300 Message-ID: <20110829165624.GA3003@amt.cnet> References: <2e43e3a409b7fa5f4781e30f3d7b7e56aa5d1fb0.1314398066.git.udeshpan@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, qemu-devel@nongnu.org To: Umesh Deshpande Return-path: Received: from mx1.redhat.com ([209.132.183.28]:26813 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754485Ab1H2Suv (ORCPT ); Mon, 29 Aug 2011 14:50:51 -0400 Content-Disposition: inline In-Reply-To: <2e43e3a409b7fa5f4781e30f3d7b7e56aa5d1fb0.1314398066.git.udeshpan@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Sat, Aug 27, 2011 at 02:09:44PM -0400, Umesh Deshpande wrote: > Currently, when any thread other than iothread calls vm_stop, it is scheduled to > be executed later by the iothread. This patch allows the execution of vm_stop > from threads other than iothread. This is especially helpful when the migration is > moved into a separate thread. > > Signed-off-by: Umesh Deshpande > --- > cpus.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/cpus.c b/cpus.c > index de70e02..f35f683 100644 > --- a/cpus.c > +++ b/cpus.c > @@ -122,8 +122,8 @@ static void do_vm_stop(int reason) > { > if (vm_running) { > cpu_disable_ticks(); > - vm_running = 0; > pause_all_vcpus(); > + vm_running = 0; > vm_state_notify(0, reason); > qemu_aio_flush(); > bdrv_flush_all(); Why this change?