From: Gleb Natapov <gleb@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Sasha Levin <levinsasha928@gmail.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
Avi Kivity <avi@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
"Tian, Kevin" <kevin.tian@intel.com>
Subject: Re: [PATCH v2] KVM: Implement support for the RH bit
Date: Fri, 2 Sep 2011 18:03:39 +0300 [thread overview]
Message-ID: <20110902150339.GI26451@redhat.com> (raw)
In-Reply-To: <4E60EDC3.1050908@siemens.com>
On Fri, Sep 02, 2011 at 04:52:51PM +0200, Jan Kiszka wrote:
> >> That's debatable. delivery_mode == APIC_DM_LOWEST includes this target
> >> selection, but also more. I have a bad feeling when we just overwrite
> >> delivery_mode as defined by the MSI data field instead of only patching
> >> kvm_irq_delivery_to_apic or kvm_is_dm_lowest_prio - if required.
> >>
> > Patching them how? To behave exactly like delivery_mode == APIC_DM_LOWEST in
> > case RH bit is set? Then setting delivery_mode to APIC_DM_LOWEST will
> > achieve the same goal.
>
> /Wrt selecting the target CPU, but not regarding the vector type
> delivered to that CPU (think of obscure things like RH=1,
> delivery_mode=APIC_DM_NMI). If RH=1 only meant hard-wiring delivery_mode
> to single value, then this would be redundant encoding. And that's
> always suspicious (unless there is legacy involved).
>
Hmm, good point.
--
Gleb.
next prev parent reply other threads:[~2011-09-02 15:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-02 7:48 [PATCH v2] KVM: Implement support for the RH bit Sasha Levin
2011-09-02 11:27 ` Jan Kiszka
2011-09-02 11:36 ` Jan Kiszka
2011-09-02 12:11 ` Jan Kiszka
2011-09-02 13:13 ` Sasha Levin
2011-09-02 14:00 ` Jan Kiszka
2011-09-02 14:11 ` Sasha Levin
2011-09-02 14:25 ` Jan Kiszka
2011-09-02 14:30 ` Sasha Levin
2011-09-02 14:36 ` Jan Kiszka
2011-09-02 14:44 ` Gleb Natapov
2011-09-02 14:52 ` Jan Kiszka
2011-09-02 15:03 ` Gleb Natapov [this message]
2011-09-02 12:25 ` Gleb Natapov
2011-09-02 13:00 ` Jan Kiszka
2011-09-02 14:22 ` Gleb Natapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110902150339.GI26451@redhat.com \
--to=gleb@redhat.com \
--cc=avi@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=levinsasha928@gmail.com \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox