From mboxrd@z Thu Jan  1 00:00:00 1970
From: Cyrill Gorcunov <gorcunov@gmail.com>
Subject: Re: [PATCH 4/5] kvm tools: Teach 'run' to handle guestfs
Date: Tue, 6 Sep 2011 17:37:10 +0400
Message-ID: <20110906133710.GN761@sun>
References: <1315265035-9496-1-git-send-email-levinsasha928@gmail.com>
 <1315265035-9496-4-git-send-email-levinsasha928@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: penberg@kernel.org, kvm@vger.kernel.org, mingo@elte.hu,
	asias.hejun@gmail.com
To: Sasha Levin <levinsasha928@gmail.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-bw0-f46.google.com ([209.85.214.46]:38251 "EHLO
	mail-bw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754536Ab1IFNhQ (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 6 Sep 2011 09:37:16 -0400
Received: by bke11 with SMTP id 11so5415118bke.19
        for <kvm@vger.kernel.org>; Tue, 06 Sep 2011 06:37:15 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1315265035-9496-4-git-send-email-levinsasha928@gmail.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Tue, Sep 06, 2011 at 02:23:54AM +0300, Sasha Levin wrote:
> This patch allows to run previously created guestfs by simply specifying it
> with the '-d' parameter.
> 
> This allows running guestfs which were created before using:
> 
> 	kvm setup -n [name]
> 
> Signed-off-by: Sasha Levin <levinsasha928@gmail.com>
> ---
...
> @@ -103,6 +104,7 @@ static int img_name_parser(const struct option *opt, const char *arg, int unset)
>  {
>  	char *sep;
>  	struct stat st;
> +	char path[PATH_MAX];
>  

Hi Sasha, the whole series looks good to me, thanks a lot!
The only thing which was always bothering me -- is PATH_MAX on the stack.
As far as I remember it might be up to 4K which is not that good ;) Probably
we might move it somewhere into .bss? (in some patches on top)

	Cyrill