From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Roedel, Joerg" Subject: Re: [PATCH 02/10] Driver core: Add iommu_ops to bus_type Date: Tue, 13 Sep 2011 17:38:11 +0200 Message-ID: <20110913153811.GO11701@amd.com> References: <1315410113-26608-1-git-send-email-joerg.roedel@amd.com> <1315410113-26608-3-git-send-email-joerg.roedel@amd.com> <20110907184750.GA920@suse.de> <20110907191919.GA31674@8bytes.org> <20110907194445.GA2526@suse.de> <20110913145402.GM11701@amd.com> <20110913145855.GA4581@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Cc: Joerg Roedel , "iommu@lists.linux-foundation.org" , Alex Williamson , Ohad Ben-Cohen , David Woodhouse , David Brown , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" To: Greg KH Return-path: Received: from ch1ehsobe006.messaging.microsoft.com ([216.32.181.186]:51314 "EHLO ch1outboundpool.messaging.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754153Ab1IMPkF (ORCPT ); Tue, 13 Sep 2011 11:40:05 -0400 Content-Disposition: inline In-Reply-To: <20110913145855.GA4581@suse.de> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, Sep 13, 2011 at 10:58:55AM -0400, Greg KH wrote: > On Tue, Sep 13, 2011 at 04:54:02PM +0200, Roedel, Joerg wrote: > > --- a/include/linux/device.h > > +++ b/include/linux/device.h > > @@ -22,6 +22,7 @@ > > #include > > #include > > #include > > +#include > > Ick, please don't add new #includes to device.h, it makes the whole > build slower. Just pre-declare the structure and all should be fine. Hmm, since linux/iommu.h provides 'struct iommu_ops', and this patch adds a 'struct iommu_ops' to 'struct bus_type', wouldn't a simple forward declaration make the bus_type incomplete in most other places? To lower the impact I can move the 'struct iommu_ops' to a seperate header file instead. Joerg -- AMD Operating System Research Center Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach General Managers: Alberto Bozzo, Andrew Bowd Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632