From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [SeaBIOS PATCH 2/2] hotplug: Add device per func in ACPI DSDT tables Date: Mon, 19 Sep 2011 12:49:23 +0300 Message-ID: <20110919094923.GA5745@redhat.com> References: <20110919065307.22802.51309.stgit@t> <20110919065347.22802.53640.stgit@t> <20110919093644.GC4501@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: seabios@seabios.org, kvm@vger.kernel.org, jasowang@redhat.com, mtosatti@redhat.com, alex.williamson@redhat.com, kevin@koconnor.net To: Amos Kong Return-path: Received: from mx1.redhat.com ([209.132.183.28]:43075 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752021Ab1ISJsd (ORCPT ); Mon, 19 Sep 2011 05:48:33 -0400 Content-Disposition: inline In-Reply-To: <20110919093644.GC4501@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Mon, Sep 19, 2011 at 12:36:44PM +0300, Michael S. Tsirkin wrote: > On Mon, Sep 19, 2011 at 02:53:47PM +0800, Amos Kong wrote: > > Only func 0 is registered to guest driver (we can > > only found func 0 in slot->funcs list of driver), > > the other functions could not be cleaned when > > hot-removing the whole slot. This patch adds > > device per function in ACPI DSDT tables. > > > > Have tested with linux/winxp/win7, hot-adding/hot-remving, > > single/multiple function device, they are all fine. > > > > Signed-off-by: Amos Kong > > On top of my previous patch, the below saves another 6K by moving the > method to the correct scope. The code for hotplug handling > also gets better organized this way which is nice. > > Signed-off-by: Michael S. Tsirkin To clarify: both this and the previous patch are only compiled, not tested.