From: "Michael S. Tsirkin" <mst@redhat.com>
To: Amos Kong <akong@redhat.com>
Cc: seabios@seabios.org, kvm@vger.kernel.org, jasowang@redhat.com,
mtosatti@redhat.com, alex.williamson@redhat.com,
kevin@koconnor.net
Subject: Re: [SeaBIOS PATCH 2/2] hotplug: Add device per func in ACPI DSDT tables
Date: Mon, 19 Sep 2011 13:04:35 +0300 [thread overview]
Message-ID: <20110919100434.GA6764@redhat.com> (raw)
In-Reply-To: <20110919093644.GC4501@redhat.com>
On Mon, Sep 19, 2011 at 12:36:44PM +0300, Michael S. Tsirkin wrote:
> On Mon, Sep 19, 2011 at 02:53:47PM +0800, Amos Kong wrote:
> > Only func 0 is registered to guest driver (we can
> > only found func 0 in slot->funcs list of driver),
> > the other functions could not be cleaned when
> > hot-removing the whole slot. This patch adds
> > device per function in ACPI DSDT tables.
> >
> > Have tested with linux/winxp/win7, hot-adding/hot-remving,
> > single/multiple function device, they are all fine.
> >
> > Signed-off-by: Amos Kong <akong@redhat.com>
>
> On top of my previous patch, the below saves another 6K by moving the
> method to the correct scope. The code for hotplug handling
> also gets better organized this way which is nice.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
We naturally should cleanup the old macro, it's unused now,
even though this doe snot save space :)
diff --git a/src/acpi-dsdt.dsl b/src/acpi-dsdt.dsl
index 36467ea..646f146 100644
--- a/src/acpi-dsdt.dsl
+++ b/src/acpi-dsdt.dsl
@@ -523,7 +523,7 @@ DefinitionBlock (
Notify(S##nr##5, 1) \
Notify(S##nr##6, 1) \
Notify(S##nr##7, 1) \
- } \
+ } \
If (And(PCID, ShiftLeft(1, nr))) { \
Notify(S##nr##0, 3) \
Notify(S##nr##1, 3) \
@@ -910,28 +910,6 @@ DefinitionBlock (
Return(0x01)
}
-#define gen_pci_hotplug(nr) \
- If (And(\_SB.PCI0.PCIU, ShiftLeft(1, nr))) { \
- Notify(\_SB.PCI0.S##nr##0, 1) \
- Notify(\_SB.PCI0.S##nr##1, 1) \
- Notify(\_SB.PCI0.S##nr##2, 1) \
- Notify(\_SB.PCI0.S##nr##3, 1) \
- Notify(\_SB.PCI0.S##nr##4, 1) \
- Notify(\_SB.PCI0.S##nr##5, 1) \
- Notify(\_SB.PCI0.S##nr##6, 1) \
- Notify(\_SB.PCI0.S##nr##7, 1) \
- } \
- If (And(\_SB.PCI0.PCID, ShiftLeft(1, nr))) { \
- Notify(\_SB.PCI0.S##nr##0, 3) \
- Notify(\_SB.PCI0.S##nr##1, 3) \
- Notify(\_SB.PCI0.S##nr##2, 3) \
- Notify(\_SB.PCI0.S##nr##3, 3) \
- Notify(\_SB.PCI0.S##nr##4, 3) \
- Notify(\_SB.PCI0.S##nr##5, 3) \
- Notify(\_SB.PCI0.S##nr##6, 3) \
- Notify(\_SB.PCI0.S##nr##7, 3) \
- }
-
Method(_L01) {
\_SB.PCI0.HPLG()
Return (0x01)
prev parent reply other threads:[~2011-09-19 10:03 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-19 6:53 [SEABIOS PATCH 0/2] fix of hotplug multi-func device Amos Kong
2011-09-19 6:53 ` [SeaBIOS PATCH 1/2] Fix regression of commit 87b533bf Amos Kong
2011-09-19 7:27 ` [SeaBIOS PATCH 2/2] hotplug: Add device per func in ACPI DSDT tables Amos Kong
2011-09-19 9:57 ` [SeaBIOS] " Gleb Natapov
2011-09-19 10:02 ` Michael S. Tsirkin
2011-09-19 10:12 ` Gleb Natapov
2011-09-19 10:32 ` Gleb Natapov
2011-09-19 12:18 ` [SeaBIOS] " Michael S. Tsirkin
2011-09-19 16:27 ` Marcelo Tosatti
2011-09-19 19:08 ` Michael S. Tsirkin
2011-09-20 10:45 ` [SeaBIOS PATCH v2] " Amos Kong
2011-09-20 11:47 ` Marcelo Tosatti
2011-09-21 1:48 ` Kevin O'Connor
2011-09-21 5:39 ` Amos Kong
2011-09-21 11:09 ` Michael S. Tsirkin
2011-09-21 12:47 ` Kevin O'Connor
2011-09-21 13:14 ` Michael S. Tsirkin
2011-12-06 5:39 ` [SeaBIOS PATCH v3] " Amos Kong
2011-12-06 11:36 ` Michael S. Tsirkin
2011-12-07 0:32 ` Amos Kong
2011-12-14 1:06 ` Kevin O'Connor
2011-12-19 8:45 ` Amos Kong
2011-09-20 10:44 ` [SeaBIOS PATCH] " Amos Kong
2011-09-20 11:42 ` Marcelo Tosatti
2011-09-20 8:00 ` [SeaBIOS PATCH v2] Fix regression of commit 87b533bf Amos Kong
2011-09-20 23:52 ` Kevin O'Connor
[not found] ` <20110919065347.22802.53640.stgit@t>
[not found] ` <20110919093644.GC4501@redhat.com>
2011-09-19 9:49 ` [SeaBIOS PATCH 2/2] hotplug: Add device per func in ACPI DSDT tables Michael S. Tsirkin
2011-09-19 10:04 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110919100434.GA6764@redhat.com \
--to=mst@redhat.com \
--cc=akong@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=jasowang@redhat.com \
--cc=kevin@koconnor.net \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=seabios@seabios.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).