Re: [PATCH v2] KVM: Fix simultaneous NMIs

Avi Kivity
2011-09-20T17:28:08Z

On 09/20/2011 07:30 PM, Marcelo Tosatti wrote:
> > >
> > >> We do have a small issue. If we exit during NMI-blocked-by-STI and
> > >> nmi_pending == 2, then we lose the second interrupt. Should rarely
> > >> happen, since external interrupts never exit in that condition, but
> > >> it's a wart.
> > >
> > >And the above system reset case, you should be able to handle it by
> > >saving/restoring nmi_queued (so that QEMU can zero it in vcpu_reset).
> >
> > We could just add a KVM_CAP (and flag) that extends nmi_pending from
> > a bool to a counter.
>
> Or just add a new field to the pad.
>

Okay; I'll address this in a follow-on patch (my preference is making
nmi_pending a counter).

--
error compiling committee.c: too many arguments to function