From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin O'Connor Subject: Re: [SeaBIOS PATCH v2] Fix regression of commit 87b533bf Date: Tue, 20 Sep 2011 19:52:18 -0400 Message-ID: <20110920235218.GA3369@morn.localdomain> References: <20110919065338.22802.48911.stgit@t> <2f5dea21-18c1-425f-bb4c-7845fd910b0a@zmail05.collab.prod.int.phx2.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: seabios@seabios.org, kvm@vger.kernel.org, mst@redhat.com, jasowang@redhat.com, mtosatti@redhat.com, alex williamson To: Amos Kong Return-path: Received: from mail-qy0-f181.google.com ([209.85.216.181]:61587 "EHLO mail-qy0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752018Ab1ITXwW (ORCPT ); Tue, 20 Sep 2011 19:52:22 -0400 Received: by qyk7 with SMTP id 7so1140398qyk.19 for ; Tue, 20 Sep 2011 16:52:21 -0700 (PDT) Content-Disposition: inline In-Reply-To: <2f5dea21-18c1-425f-bb4c-7845fd910b0a@zmail05.collab.prod.int.phx2.redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, Sep 20, 2011 at 04:00:57AM -0400, Amos Kong wrote: > From 4678a3cb0e0a3cd7a4bc3d284c5719fdba90bc61 Mon Sep 17 00:00:00 2001 > From: Kevin O'Connor > Date: Tue, 20 Sep 2011 15:43:55 +0800 > Subject: [PATCH V2] Fix regression of commit 87b533bf > > From: Kevin O'Connor > > After adding more device entries in ACPI DSDT tables, > the filesize of bios.bin changed from 128K to 256K. > But bios could not initialize successfully. > > This is a regression since seabios commit 87b533bf. Prior to > that commit, seabios did not mark the early 32bit initialization > code as init code. However, a side effect of marking that code > (handle_post) as init code is that it is more likely the linker > could place the code at an address less than 0xe0000. > The patch (just a hack) would cover up the issue. Thanks. I committed a slightly different patch (but similar concept) to the seabios repo. -Kevin