From: Kevin O'Connor <kevin@koconnor.net>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Amos Kong <akong@redhat.com>,
seabios@seabios.org, Gleb Natapov <gleb@redhat.com>,
kvm@vger.kernel.org, jasowang@redhat.com,
alex williamson <alex.williamson@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [PATCH 0/4] acpi: fix up EJ0 in DSDT
Date: Thu, 22 Sep 2011 00:35:13 -0400 [thread overview]
Message-ID: <20110922043513.GA488@morn.localdomain> (raw)
In-Reply-To: <cover.1316608551.git.mst@redhat.com>
On Wed, Sep 21, 2011 at 03:44:13PM +0300, Michael S. Tsirkin wrote:
> The reason is that our acpi tables declare both _RMV with value 0,
> and _EJ0 method for these slots. What happens in this case
> is undocumented by ACPI spec, so linux ignores _RMV,
> and windows seems to ignore _EJ0.
Could the DSDT just not define _EJ0 for device 1 & 2 instead of
dynamically patching them? (Would there ever be a case where we
wouldn't know at compile time which devices need _EJ0?)
> The correct way to suppress hotplug is not to have _EJ0,
> so this is what this patch does: it probes PIIX and
> modifies DSDT to match.
The code to generate basic SSDT code isn't that difficult (see
build_ssdt and src/ssdt-proc.dsl). Is there a compelling reason to
patch the DSDT versus just generating the necessary blocks in an SSDT?
-Kevin
next prev parent reply other threads:[~2011-09-22 4:35 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-21 12:44 [PATCH 0/4] acpi: fix up EJ0 in DSDT Michael S. Tsirkin
2011-09-21 12:44 ` [PATCH 1/4] acpi: generate mixed asl/aml listing Michael S. Tsirkin
2011-09-21 12:47 ` Michael S. Tsirkin
2011-09-21 12:44 ` [PATCH 2/4] acpi: add aml/asl parsing script Michael S. Tsirkin
2011-09-21 14:27 ` Gleb Natapov
2011-09-21 15:46 ` Michael S. Tsirkin
2011-09-21 18:10 ` Michael S. Tsirkin, Kevin O'Connor
2011-09-21 12:44 ` [PATCH 3/4] acpi: EJ0 method name patching Michael S. Tsirkin
2011-09-21 12:44 ` [PATCH 4/4] acpi: remove _RMV Michael S. Tsirkin
2011-09-22 4:35 ` Kevin O'Connor [this message]
2011-09-22 6:09 ` [PATCH 0/4] acpi: fix up EJ0 in DSDT Michael S. Tsirkin
2011-09-22 12:39 ` Kevin O'Connor
2011-09-26 4:40 ` Kevin O'Connor
2011-09-26 7:03 ` [SeaBIOS] " Rudolf Marek
2011-09-26 7:04 ` Michael S. Tsirkin
2011-09-26 11:36 ` Marcelo Tosatti
2011-09-26 13:13 ` Michael S. Tsirkin
2011-09-27 0:04 ` Kevin O'Connor
2011-09-27 13:04 ` Michael S. Tsirkin
2011-09-27 15:23 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110922043513.GA488@morn.localdomain \
--to=kevin@koconnor.net \
--cc=akong@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=gleb@redhat.com \
--cc=jasowang@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
--cc=seabios@seabios.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox