From: Alex Williamson <alex.williamson@redhat.com>
To: kvm@vger.kernel.org
Cc: jan.kiszka@siemens.com, avi@redhat.com, yongjie.ren@intel.com,
alex.williamson@redhat.com
Subject: [PATCH v2 1/2] pci-assign: Re-order initfn for memory API
Date: Thu, 22 Sep 2011 12:09:01 -0600 [thread overview]
Message-ID: <20110922180901.13603.66502.stgit@s20.home> (raw)
In-Reply-To: <20110922180823.13603.57187.stgit@s20.home>
We now need to scan PCI capabilities and setup an MSI-X page
before we walk the device resources since the overlay is now
setup during init instead of at the first mapping by the guest.
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
---
hw/device-assignment.c | 19 +++++++++++--------
1 files changed, 11 insertions(+), 8 deletions(-)
diff --git a/hw/device-assignment.c b/hw/device-assignment.c
index 288f80c..137c409 100644
--- a/hw/device-assignment.c
+++ b/hw/device-assignment.c
@@ -1603,6 +1603,17 @@ static int assigned_initfn(struct PCIDevice *pci_dev)
goto out;
}
+ if (assigned_device_pci_cap_init(pci_dev) < 0) {
+ goto out;
+ }
+
+ /* intercept MSI-X entry page in the MMIO */
+ if (dev->cap.available & ASSIGNED_DEVICE_CAP_MSIX) {
+ if (assigned_dev_register_msix_mmio(dev)) {
+ goto out;
+ }
+ }
+
/* handle real device's MMIO/PIO BARs */
if (assigned_dev_register_regions(dev->real_device.regions,
dev->real_device.region_number,
@@ -1618,9 +1629,6 @@ static int assigned_initfn(struct PCIDevice *pci_dev)
dev->h_busnr = dev->host.bus;
dev->h_devfn = PCI_DEVFN(dev->host.dev, dev->host.func);
- if (assigned_device_pci_cap_init(pci_dev) < 0)
- goto out;
-
/* assign device to guest */
r = assign_device(dev);
if (r < 0)
@@ -1631,11 +1639,6 @@ static int assigned_initfn(struct PCIDevice *pci_dev)
if (r < 0)
goto assigned_out;
- /* intercept MSI-X entry page in the MMIO */
- if (dev->cap.available & ASSIGNED_DEVICE_CAP_MSIX)
- if (assigned_dev_register_msix_mmio(dev))
- goto assigned_out;
-
assigned_dev_load_option_rom(dev);
QLIST_INSERT_HEAD(&devs, dev, next);
next prev parent reply other threads:[~2011-09-22 18:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-22 18:08 [PATCH v2 0/2] pci-assign: Fix MSI-X support Alex Williamson
2011-09-22 18:09 ` Alex Williamson [this message]
2011-09-22 18:09 ` [PATCH v2 2/2] pci-assign: Fix MSI-X capability test Alex Williamson
2011-09-23 17:00 ` [PATCH v2 0/2] pci-assign: Fix MSI-X support Jan Kiszka
2011-10-03 19:39 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110922180901.13603.66502.stgit@s20.home \
--to=alex.williamson@redhat.com \
--cc=avi@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=yongjie.ren@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox