From: Marcelo Tosatti <mtosatti@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: kvm@vger.kernel.org, Jan Kiszka <jan.kiszka@siemens.com>
Subject: Re: [PATCH v2] KVM: Fix simultaneous NMIs
Date: Fri, 23 Sep 2011 08:54:47 -0300 [thread overview]
Message-ID: <20110923115447.GB29561@amt.cnet> (raw)
In-Reply-To: <20110921164449.GA21142@amt.cnet>
On Wed, Sep 21, 2011 at 01:44:49PM -0300, Marcelo Tosatti wrote:
> On Wed, Sep 21, 2011 at 11:46:03AM +0300, Avi Kivity wrote:
> > On 09/20/2011 08:28 PM, Avi Kivity wrote:
> > >On 09/20/2011 07:30 PM, Marcelo Tosatti wrote:
> > >>> >
> > >>> >> We do have a small issue. If we exit during
> > >>NMI-blocked-by-STI and
> > >>> >> nmi_pending == 2, then we lose the second interrupt.
> > >>Should rarely
> > >>> >> happen, since external interrupts never exit in that
> > >>condition, but
> > >>> >> it's a wart.
>
> Actually exits in the window between
>
> - increase of nmi_queued
> and
> - transfer to nmi_pending/nmi_injected
>
> Lose all nmi_queued values, no?
Applied the patch, please fix save/restore later, thanks.
prev parent reply other threads:[~2011-09-23 12:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-20 10:43 [PATCH v2] KVM: Fix simultaneous NMIs Avi Kivity
2011-09-20 13:25 ` Marcelo Tosatti
2011-09-20 13:56 ` Avi Kivity
2011-09-20 14:59 ` Marcelo Tosatti
2011-09-20 16:24 ` Avi Kivity
2011-09-20 16:30 ` Marcelo Tosatti
2011-09-20 17:28 ` Avi Kivity
2011-09-21 8:46 ` Avi Kivity
2011-09-21 16:44 ` Marcelo Tosatti
2011-09-23 11:54 ` Marcelo Tosatti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110923115447.GB29561@amt.cnet \
--to=mtosatti@redhat.com \
--cc=avi@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox