From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [PATCH v2] KVM: Fix simultaneous NMIs
Date: Fri, 23 Sep 2011 08:54:47 -0300
Message-ID: <20110923115447.GB29561@amt.cnet>
References: <1316515394-24762-1-git-send-email-avi@redhat.com>
 <20110920132537.GA27075@amt.cnet>
 <4E789B72.2050904@redhat.com>
 <20110920145946.GA28219@amt.cnet>
 <4E78BE21.4070508@redhat.com>
 <20110920163021.GA29618@amt.cnet>
 <4E78CD23.5000705@redhat.com>
 <4E79A44B.8090704@redhat.com>
 <20110921164449.GA21142@amt.cnet>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: kvm@vger.kernel.org, Jan Kiszka <jan.kiszka@siemens.com>
To: Avi Kivity <avi@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:64855 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753753Ab1IWMiJ (ORCPT <rfc822;kvm@vger.kernel.org>);
	Fri, 23 Sep 2011 08:38:09 -0400
Content-Disposition: inline
In-Reply-To: <20110921164449.GA21142@amt.cnet>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Wed, Sep 21, 2011 at 01:44:49PM -0300, Marcelo Tosatti wrote:
> On Wed, Sep 21, 2011 at 11:46:03AM +0300, Avi Kivity wrote:
> > On 09/20/2011 08:28 PM, Avi Kivity wrote:
> > >On 09/20/2011 07:30 PM, Marcelo Tosatti wrote:
> > >>> >
> > >>> >>   We do have a small issue.  If we exit during
> > >>NMI-blocked-by-STI and
> > >>> >>   nmi_pending == 2, then we lose the second interrupt.
> > >>Should rarely
> > >>> >>   happen, since external interrupts never exit in that
> > >>condition, but
> > >>> >>   it's a wart.
> 
> Actually exits in the window between 
> 
> - increase of nmi_queued 
> and 
> - transfer to nmi_pending/nmi_injected
> 
> Lose all nmi_queued values, no?

Applied the patch, please fix save/restore later, thanks.