From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [PATCHv2 0/3] acpi: fix up EJ0 in DSDT Date: Fri, 23 Sep 2011 11:47:12 -0300 Message-ID: <20110923144712.GA1618@amt.cnet> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Amos Kong , "Kevin O'Connor" , seabios@seabios.org, Gleb Natapov , kvm@vger.kernel.org, jasowang@redhat.com, alex williamson To: "Michael S. Tsirkin" Return-path: Received: from mx1.redhat.com ([209.132.183.28]:13685 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753925Ab1IWOsi (ORCPT ); Fri, 23 Sep 2011 10:48:38 -0400 Content-Disposition: inline In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On Thu, Sep 22, 2011 at 02:37:16PM +0300, Michael S. Tsirkin wrote: > This is a second iteration of the patch. The patch has been > significantly reworked to address (offline) comments by Gleb. > > I think the infrastructure created is generic enough > to be generally useful beyond the specific bug > that I would like to fix. Specifically it > will be able to find S3 Name to patch that, > or process compiled CPU SSDT to avoid the need for > hardcoded offsets. > > Please comment. > > Main changes: > - tools rewritten in python > - Original ASL retains _EJ0 methods, BIOS patches that to EJ0_ > - generic ACP_EXTRACT infrastructure that can match Method > and Name Operators > - instead of matching specific method name, insert tags > in original DSL source and match that to AML > > ----- Neat, looks good to me.