From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [RFC][PATCH 08/45] Introduce MSIMessage structure Date: Mon, 17 Oct 2011 14:04:05 +0200 Message-ID: <20111017120404.GG4537@redhat.com> References: <963bfdb7ee30cd65bec92c89cc04af0363de86c8.1318843693.git.jan.kiszka@siemens.com> <20111017114612.GE4537@redhat.com> <4E9C16A4.9030402@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Avi Kivity , Marcelo Tosatti , "kvm@vger.kernel.org" , Alex Williamson , "qemu-devel@nongnu.org" To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:52202 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751442Ab1JQMDJ (ORCPT ); Mon, 17 Oct 2011 08:03:09 -0400 Content-Disposition: inline In-Reply-To: <4E9C16A4.9030402@siemens.com> Sender: kvm-owner@vger.kernel.org List-ID: On Mon, Oct 17, 2011 at 01:51:00PM +0200, Jan Kiszka wrote: > On 2011-10-17 13:46, Michael S. Tsirkin wrote: > > On Mon, Oct 17, 2011 at 11:27:42AM +0200, Jan Kiszka wrote: > >> Will be used for generating and distributing MSI messages, both in > >> emulation mode and under KVM. > >> > >> Signed-off-by: Jan Kiszka > > > > I would add > > > > uint64_t msix_get_address(dev, vector) > > uint64_t msix_get_data(dev, vector) > > > > and same for msi. > > > > this would minimise the changes while still making it > > possible to avoid code duplication in kvm. > > I'm introducing msi[x]_message_from_vector for that purpose later on. Or > what do you mean? > > Jan It does not look like everyone actually wants the structure, users seem to put it on stack and then immediately unwrap it to get at the address/data. So two accessorts get_data + get_address instead of one, will remove the need to rework all code to use the structure. > -- > Siemens AG, Corporate Technology, CT T DE IT 1 > Corporate Competence Center Embedded Linux