From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH 4/5] msix: Don't process table changes while disabled Date: Tue, 18 Oct 2011 14:01:51 +0200 Message-ID: <20111018120151.GG28776@redhat.com> References: <16be9aa8fe4b5ebef73192c487b3cdf61c7a14a9.1318924251.git.jan.kiszka@siemens.com> <20111018111809.GC28776@redhat.com> <4E9D6489.7000608@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Avi Kivity , Marcelo Tosatti , "kvm@vger.kernel.org" To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:46768 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754132Ab1JRMAr (ORCPT ); Tue, 18 Oct 2011 08:00:47 -0400 Content-Disposition: inline In-Reply-To: <4E9D6489.7000608@siemens.com> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, Oct 18, 2011 at 01:35:37PM +0200, Jan Kiszka wrote: > On 2011-10-18 13:18, Michael S. Tsirkin wrote: > > On Tue, Oct 18, 2011 at 09:50:53AM +0200, Jan Kiszka wrote: > >> As long as MSI-X is disabled, it's incorrect to invoke > >> msix_handle_mask_update on per-vector mask changes. That may misguide > >> the config notifier callback or spuriously trigger an MSI event. > >> > >> Signed-off-by: Jan Kiszka > > > > Same question as on the previous patch. At the moment, the only user > > (virtio) seems to check msix_enabled before registering > > notifiers. See virtio_pci_query_guest_notifiers. > > Is there some way you see to trigger incorrect behaviour? > > Then it's not an urgent fix, just a conceptual one (the user should not > have to worry about enable/disabled, we want the core to do the boring > jobs). > > Jan Yes, I agree the callback APIs could use some cleanup. Need to make sure the patch does not cause unbalanced mask/unmask calls. I need to look closer to check that's still the case. > -- > Siemens AG, Corporate Technology, CT T DE IT 1 > Corporate Competence Center Embedded Linux