From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [PATCH] pci-assign: Fix MSI-X MMIO page registration Date: Wed, 19 Oct 2011 13:53:47 -0200 Message-ID: <20111019155347.GB7582@amt.cnet> References: <4E95C82D.3090306@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Avi Kivity , kvm , Alex Williamson To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:8650 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756722Ab1JSPzF (ORCPT ); Wed, 19 Oct 2011 11:55:05 -0400 Content-Disposition: inline In-Reply-To: <4E95C82D.3090306@siemens.com> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, Oct 12, 2011 at 07:02:37PM +0200, Jan Kiszka wrote: > The MSI-X page must start below the address that comes after the end of > a region. Otherwise we risk to register it twice. This bug existed since > day #1 of the MSI-X support and was now reveal by > > memory.c:1201: memory_region_add_subregion_common: Assertion `!subregion->parent' failed. > > Signed-off-by: Jan Kiszka > --- > hw/device-assignment.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Applied, thanks.