From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin O'Connor Subject: Re: [PATCH RFC] acpi: extract aml from .lst Date: Thu, 27 Oct 2011 20:08:54 -0400 Message-ID: <20111028000854.GC16619@morn.localdomain> References: <20111026212801.GA12953@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: seabios@seabios.org, kvm@vger.kernel.org To: "Michael S. Tsirkin" Return-path: Received: from mail-qy0-f174.google.com ([209.85.216.174]:60227 "EHLO mail-qy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750708Ab1J1AI4 (ORCPT ); Thu, 27 Oct 2011 20:08:56 -0400 Received: by qyk4 with SMTP id 4so1483961qyk.19 for ; Thu, 27 Oct 2011 17:08:56 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20111026212801.GA12953@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, Oct 26, 2011 at 11:28:02PM +0200, Michael S. Tsirkin wrote: > Add ACPI_EXTRACT_ALL_CODE directive, to support extracting > AML code from listing into a named array. Use that instead including C > file generated by iasl, this makes it possible to include multiple AML > tables without resorting to preprocessor tricks. > > Signed-off-by: Michael S. Tsirkin > > --- > > Kevin, you suggested something like the below, I think? Seems to work > but RFC since I didn't have time to test this properly. It looks okay to me (I didn't do any exhaustive tests either). It would be preferable if we didn't have to change the acpi-dsdt.dsl file though - that way users could still compile it with the iasl compiler directly. Can the output default to "AmlCode" if no directive is found? -Kevin