From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
"Hans J. Koch" <hjk@hansjkoch.de>,
Greg Kroah-Hartman <gregkh@suse.de>,
"Michael S. Tsirkin" <mst@redhat.com>,
kvm@vger.kernel.org, Brian King <brking@linux.vnet.ibm.com>
Subject: Re: [PATCH 1/3] pci: Rework config space blocking services
Date: Wed, 2 Nov 2011 13:59:51 -0700 [thread overview]
Message-ID: <20111102135951.3bce8b08@jbarnes-desktop> (raw)
In-Reply-To: <33234f96f761babf0e61dfe2cb5fe87cadc98d60.1315846441.git.jan.kiszka@siemens.com>
[-- Attachment #1: Type: text/plain, Size: 1271 bytes --]
On Mon, 12 Sep 2011 18:54:02 +0200
Jan Kiszka <jan.kiszka@siemens.com> wrote:
> pci_block_user_cfg_access was designed for the use case that a single
> context, the IPR driver, temporarily delays user space accesses to the
> config space via sysfs. This assumption became invalid by the time
> pci_dev_reset was added as locking instance. Today, if you run two loops
> in parallel that reset the same device via sysfs, you end up with a
> kernel BUG as pci_block_user_cfg_access detect the broken assumption.
>
> This reworks the pci_block_user_cfg_access to a sleeping service
> pci_cfg_access_lock and an atomic-compatible variant called
> pci_cfg_access_trylock. The former not only blocks user space access as
> before but also waits if access was already locked. The latter service
> just returns false in this case, allowing the caller to resolve the
> conflict instead of raising a BUG.
>
> Adaptions of the ipr driver were originally written by Brian King.
Sorry to ask you to refresh these after so long, Jan, but can you
respin against my linux-next branch?
My inbox is a poor substitute for patchwork, but that's no excuse for
leaving you hanging so long. Sorry!
Thanks,
--
Jesse Barnes, Intel Open Source Technology Center
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2011-11-02 20:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-12 16:54 [PATCH 0/3] PCI: Rework config space locking, add INTx masking services Jan Kiszka
2011-09-12 16:54 ` [PATCH 1/3] pci: Rework config space blocking services Jan Kiszka
2011-11-02 20:59 ` Jesse Barnes [this message]
2011-09-12 16:54 ` [PATCH 2/3] pci: Introduce INTx check & mask API Jan Kiszka
2011-09-12 16:54 ` [PATCH 3/3] uio: Convert uio_generic_pci to new intx masking API Jan Kiszka
2011-10-06 15:48 ` [PATCH 0/3] PCI: Rework config space locking, add INTx masking services Jesse Barnes
2011-10-14 14:48 ` Jan Kiszka
2011-10-25 12:32 ` Jan Kiszka
2011-10-14 15:44 ` Brian King
2011-10-16 14:25 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111102135951.3bce8b08@jbarnes-desktop \
--to=jbarnes@virtuousgeek.org \
--cc=brking@linux.vnet.ibm.com \
--cc=gregkh@suse.de \
--cc=hjk@hansjkoch.de \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mst@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox