From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH RFC] acpi: add ssdt for cpi hotplug Date: Thu, 3 Nov 2011 14:31:18 +0200 Message-ID: <20111103123117.GI18296@redhat.com> References: <20111101191139.GA18317@redhat.com> <20111101225901.GB31374@morn.localdomain> <20111102085442.GF5613@redhat.com> <20111103003028.GA16459@morn.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: seabios@seabios.org, kvm@vger.kernel.org To: "Kevin O'Connor" Return-path: Content-Disposition: inline In-Reply-To: <20111103003028.GA16459@morn.localdomain> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: seabios-bounces@seabios.org Sender: seabios-bounces@seabios.org List-Id: kvm.vger.kernel.org On Wed, Nov 02, 2011 at 08:30:28PM -0400, Kevin O'Connor wrote: > On Wed, Nov 02, 2011 at 10:54:42AM +0200, Michael S. Tsirkin wrote: > > On Tue, Nov 01, 2011 at 06:59:01PM -0400, Kevin O'Connor wrote: > > > Can we leave these parts in the DSDT and only move the bulk generated > > > stuff to the SSDT? > > > > > They can, but I thought one of the reasons we do the split > > is to make it possible for users to supply their own DSDT? > > If so creating calls from SSDT into DSDT would make this very fragile. > > I think it's reasonable to require that a user supplied DSDT still > fill certain requirements. Keep in mind that the reason for the "user > supplied" DSDT was for new platform (q35) development - not > necessarily so each individual user could set their own. > > It's not great to have the DSDT and SSDT tied to each other. However, > once RMV is removed, it's only two methods (PCNT supplied by the SSDT > and PCEJ supplied by the DSDT). > > I do see the upside to moving it all to the SSDT - but that has the > disadvantage of taking away the ability of a user supplied DSDT to > tweak how the hotplug functions work. Is this something q35 needs? > Also, we'd then want to redo CPU hotplug to be the same way. OK, I'll do that if we decide this is a good direcction. > -Kevin