From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cyrill Gorcunov Subject: Re: kvm tools: clock sources for hrtimer Date: Wed, 9 Nov 2011 23:25:34 +0400 Message-ID: <20111109192534.GF608@moon> References: <737697ff491a47a25b620f0fca60bb07@radon2.swed.at> <1320850191.31056.64.camel@lappy> <294867a39da5124eee9a2c167f0f9c87@radon2.swed.at> <1320853793.31056.75.camel@lappy> <20111109160006.GD608@moon> <1320866034.1428.94.camel@jaguar> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Richard Weinberger , Sasha Levin , kvm@vger.kernel.org, mingo@elte.hu, asias.hejun@gmail.com To: Pekka Enberg Return-path: Received: from mail-bw0-f46.google.com ([209.85.214.46]:51990 "EHLO mail-bw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752827Ab1KITZk (ORCPT ); Wed, 9 Nov 2011 14:25:40 -0500 Received: by bke11 with SMTP id 11so1648930bke.19 for ; Wed, 09 Nov 2011 11:25:39 -0800 (PST) Content-Disposition: inline In-Reply-To: <1320866034.1428.94.camel@jaguar> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, Nov 09, 2011 at 09:13:54PM +0200, Pekka Enberg wrote: ... > Yup, "notsc" was used in the early days to avoid APIC emulation. > > Anyone care to send a patch to drop it from master? > > Pekka > Here we go --- Subject: [PATCH] tools, kvm: Drop "notsc" no longer needed kernel option "notsc" option has been used to avoid APIC calibration problem at early days when we didn't support APIC at all. Now with KVM APIC emulation used there is no longer need for this option. Drop it. Reported-by: Richard Weinberger Tested-by: Richard Weinberger Signed-off-by: Cyrill Gorcunov --- tools/kvm/builtin-run.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-2.6.git/tools/kvm/builtin-run.c =================================================================== --- linux-2.6.git.orig/tools/kvm/builtin-run.c +++ linux-2.6.git/tools/kvm/builtin-run.c @@ -830,7 +830,7 @@ int kvm_cmd_run(int argc, const char **a vidmode = 0; memset(real_cmdline, 0, sizeof(real_cmdline)); - strcpy(real_cmdline, "notsc noapic noacpi pci=conf1 reboot=k panic=1 i8042.direct=1 " + strcpy(real_cmdline, "noapic noacpi pci=conf1 reboot=k panic=1 i8042.direct=1 " "i8042.dumbkbd=1 i8042.nopnp=1"); if (vnc || sdl) { strcat(real_cmdline, " video=vesafb console=tty0");