From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [PATCH] Set numa topology for max_cpus
Date: Thu, 10 Nov 2011 13:31:15 -0200
Message-ID: <20111110153115.GC7554@amt.cnet>
References: <1319631540-32611-1-git-send-email-vasilis.liaskovitis@profitbricks.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: kvm@vger.kernel.org, aliguori@us.ibm.com, avi@redhat.com,
	andre.przywara@amd.com, seabios@seabios.org
To: Vasilis Liaskovitis <vasilis.liaskovitis@profitbricks.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:48447 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S935389Ab1KJQRU (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 10 Nov 2011 11:17:20 -0500
Content-Disposition: inline
In-Reply-To: <1319631540-32611-1-git-send-email-vasilis.liaskovitis@profitbricks.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Wed, Oct 26, 2011 at 02:19:00PM +0200, Vasilis Liaskovitis wrote:
> qemu-kvm passes numa/SRAT topology information for smp_cpus to SeaBIOS. However
> SeaBIOS always expects to setup max_cpus number of SRAT cpu entries
> (MaxCountCPUs variable in build_srat function of Seabios). When qemu-kvm runs
> with smp_cpus != max_cpus (e.g. -smp 2,maxcpus=4), Seabios will mistakenly use
> memory SRAT info for setting up CPU SRAT entries for the offline CPUs. Wrong
> SRAT memory entries are also created. This breaks NUMA in a guest.
> Fix by setting up SRAT info for max_cpus in qemu-kvm.
> 
> Signed-off-by: Vasilis Liaskovitis <vasilis.liaskovitis@profitbricks.com>

Applied to uq/master, thanks.