* [PATCH] kvm-tpr-opt: Fix instruction_is_ok() for push tpr
@ 2011-11-22 9:35 Markus Armbruster
2011-11-24 0:09 ` Marcelo Tosatti
0 siblings, 1 reply; 2+ messages in thread
From: Markus Armbruster @ 2011-11-22 9:35 UTC (permalink / raw)
To: kvm; +Cc: avi
Missing break spotted by Coverity.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
kvm-tpr-opt.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/kvm-tpr-opt.c b/kvm-tpr-opt.c
index 4b2bd47..14c4b36 100644
--- a/kvm-tpr-opt.c
+++ b/kvm-tpr-opt.c
@@ -152,6 +152,7 @@ static int instruction_is_ok(CPUState *env, uint64_t rip, int is_write)
if (modrm_reg(b2) != 6 || !is_abs_modrm(b2))
return 0;
addr_offset = 2;
+ break;
default:
return 0;
}
--
1.7.6.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] kvm-tpr-opt: Fix instruction_is_ok() for push tpr
2011-11-22 9:35 [PATCH] kvm-tpr-opt: Fix instruction_is_ok() for push tpr Markus Armbruster
@ 2011-11-24 0:09 ` Marcelo Tosatti
0 siblings, 0 replies; 2+ messages in thread
From: Marcelo Tosatti @ 2011-11-24 0:09 UTC (permalink / raw)
To: Markus Armbruster; +Cc: kvm, avi
On Tue, Nov 22, 2011 at 10:35:59AM +0100, Markus Armbruster wrote:
> Missing break spotted by Coverity.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> kvm-tpr-opt.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-11-24 10:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-22 9:35 [PATCH] kvm-tpr-opt: Fix instruction_is_ok() for push tpr Markus Armbruster
2011-11-24 0:09 ` Marcelo Tosatti
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).