From mboxrd@z Thu Jan  1 00:00:00 1970
From: Cyrill Gorcunov <gorcunov@gmail.com>
Subject: Re: [PATCH] kvm tools: Split custom rootfs init into two stages
Date: Mon, 5 Dec 2011 13:30:16 +0400
Message-ID: <20111205093016.GP14515@moon>
References: <1323076931-4858-1-git-send-email-levinsasha928@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: penberg@kernel.org, kvm@vger.kernel.org, mingo@elte.hu,
	asias.hejun@gmail.com
To: Sasha Levin <levinsasha928@gmail.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-bw0-f46.google.com ([209.85.214.46]:62244 "EHLO
	mail-bw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753601Ab1LEJaV (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 5 Dec 2011 04:30:21 -0500
Received: by bkbzv3 with SMTP id zv3so1567043bkb.19
        for <kvm@vger.kernel.org>; Mon, 05 Dec 2011 01:30:20 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <1323076931-4858-1-git-send-email-levinsasha928@gmail.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Mon, Dec 05, 2011 at 11:22:11AM +0200, Sasha Levin wrote:
>  
> +static int kvm_custom_stage2(void)
> +{
> +	char tmp[PATH_MAX], dst[PATH_MAX], *src;
> +	const char *rootfs;
> +	int r;
> +
> +	src = realpath("guest/init_stage2", NULL);
> +	if (src == NULL)
> +		return -ENOMEM;
> +
> +	if (image_filename[0] == NULL)
> +		rootfs = "default";
> +	else
> +		rootfs = image_filename[0];
> +
> +	sprintf(tmp, "%s%s/virt/init_stage2", kvm__get_dir(), rootfs);
> +	remove(tmp);
> +
> +	sprintf(dst, "/host/%s", src);
> +	r = symlink(dst, tmp);
> +	free(src);
> +
> +	return r;
> +}
> +

I might be paranoid -- but could you please use snprintf here? :)