From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cyrill Gorcunov Subject: Re: [PATCH 23/28] kvm tools: Endian-sanitise pci.h and PCI device setup Date: Tue, 6 Dec 2011 14:28:56 +0400 Message-ID: <20111206102856.GB29781@moon> References: <4EDD8F16.6060104@ozlabs.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Matt Evans , kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, Asias He , Sasha Levin , Ingo Molnar To: Pekka Enberg Return-path: Content-Disposition: inline In-Reply-To: Sender: kvm-ppc-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Tue, Dec 06, 2011 at 12:25:29PM +0200, Pekka Enberg wrote: > On Tue, Dec 6, 2011 at 5:42 AM, Matt Evans wrote: > > vesa, pci-shmem and virtio-pci devices need to set up config space = with > > little-endian conversions (as config space is LE). =A0The pci_confi= g_address > > bitfield also needs to be reversed when building on BE systems. > > > > Signed-off-by: Matt Evans >=20 > Looks OK to me. Sasha, Cyrill? >=20 BIOS part looks pretty good to me. LE/BE part as well. Thanks Matt! Cyrill