From mboxrd@z Thu Jan  1 00:00:00 1970
From: Cyrill Gorcunov <gorcunov@gmail.com>
Subject: Re: [PATCH 23/28] kvm tools: Endian-sanitise pci.h and PCI device
 setup
Date: Tue, 6 Dec 2011 15:47:55 +0400
Message-ID: <20111206114755.GC29781@moon>
References: <cover.1323141075.git.matt@ozlabs.org>
 <4EDD8F16.6060104@ozlabs.org>
 <CAOJsxLH1KYeLj4i=9rNOs_f3ZS9qhgJuBO7jbLjkCDQHLbyVNw@mail.gmail.com>
 <20111206102856.GB29781@moon>
 <CAOJsxLHehE9Dr-c-6tCsPYh5tr0Sm_CsycAUUg=6=Rjb2kPFEQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: Matt Evans <matt@ozlabs.org>, kvm@vger.kernel.org,
	kvm-ppc@vger.kernel.org, Asias He <asias.hejun@gmail.com>,
	Sasha Levin <levinsasha928@gmail.com>,
	Ingo Molnar <mingo@elte.hu>
To: Pekka Enberg <penberg@kernel.org>
Return-path: <kvm-ppc-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <CAOJsxLHehE9Dr-c-6tCsPYh5tr0Sm_CsycAUUg=6=Rjb2kPFEQ@mail.gmail.com>
Sender: kvm-ppc-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org

On Tue, Dec 06, 2011 at 01:41:56PM +0200, Pekka Enberg wrote:
> On Tue, Dec 6, 2011 at 12:28 PM, Cyrill Gorcunov <gorcunov@gmail.com>=
 wrote:
> > On Tue, Dec 06, 2011 at 12:25:29PM +0200, Pekka Enberg wrote:
> >> On Tue, Dec 6, 2011 at 5:42 AM, Matt Evans <matt@ozlabs.org> wrote=
:
> >> > vesa, pci-shmem and virtio-pci devices need to set up config spa=
ce with
> >> > little-endian conversions (as config space is LE). =A0The pci_co=
nfig_address
> >> > bitfield also needs to be reversed when building on BE systems.
> >> >
> >> > Signed-off-by: Matt Evans <matt@ozlabs.org>
> >>
> >> Looks OK to me. Sasha, Cyrill?
> >>
> >
> > BIOS part looks pretty good to me. LE/BE part as well. Thanks Matt!
>=20
> Hmm. This seems to break "make check" for me:
>

If you change back to

 static struct pci_device_header pci_shmem_pci_device =3D {
	...
	.class          =3D 0xFF0000,     /* misc pci device */
	...
 };

does it help?

	Cyrill