From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Daniel P. Berrange" Subject: Re: [libvirt] [PATCH 5/7] kvmtool: Add new domain type Date: Tue, 6 Dec 2011 14:46:40 +0000 Message-ID: <20111206144640.GC7937@redhat.com> References: <1321012626-31713-1-git-send-email-jyang@redhat.com> <1321012626-31713-7-git-send-email-jyang@redhat.com> Reply-To: "Daniel P. Berrange" Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Cc: libvir-list@redhat.com, kvm@vger.kernel.org, penberg@cs.helsinki.fi, levinsasha928@gmail.com, gorcunov@gmail.com, mingo@elte.hu, asias.hejun@gmail.com To: Osier Yang Return-path: Received: from mx1.redhat.com ([209.132.183.28]:33054 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752806Ab1LFOrW (ORCPT ); Tue, 6 Dec 2011 09:47:22 -0500 Content-Disposition: inline In-Reply-To: <1321012626-31713-7-git-send-email-jyang@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Fri, Nov 11, 2011 at 07:57:04PM +0800, Osier Yang wrote: > It's named as "kvmtool". > --- > src/conf/domain_conf.c | 4 +++- > src/conf/domain_conf.h | 1 + > 2 files changed, 4 insertions(+), 1 deletions(-) > > diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c > index 58f4d0f..55121d8 100644 > --- a/src/conf/domain_conf.c > +++ b/src/conf/domain_conf.c > @@ -91,7 +91,8 @@ VIR_ENUM_IMPL(virDomainVirt, VIR_DOMAIN_VIRT_LAST, > "hyperv", > "vbox", > "one", > - "phyp") > + "phyp", > + "kvmtool") > > VIR_ENUM_IMPL(virDomainBoot, VIR_DOMAIN_BOOT_LAST, > "fd", > @@ -4018,6 +4019,7 @@ virDomainChrDefParseXML(virCapsPtr caps, > if (type == NULL) { > def->source.type = VIR_DOMAIN_CHR_TYPE_PTY; > } else if ((def->source.type = virDomainChrTypeFromString(type)) < 0) { > + VIR_WARN("type = %s", type); > virDomainReportError(VIR_ERR_XML_ERROR, > _("unknown type presented to host for character device: %s"), > type); > diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h > index a3cb834..001bc46 100644 > --- a/src/conf/domain_conf.h > +++ b/src/conf/domain_conf.h > @@ -59,6 +59,7 @@ enum virDomainVirtType { > VIR_DOMAIN_VIRT_VBOX, > VIR_DOMAIN_VIRT_ONE, > VIR_DOMAIN_VIRT_PHYP, > + VIR_DOMAIN_VIRT_KVMTOOL, > > VIR_DOMAIN_VIRT_LAST, > }; IMHO this patch is not required. The domain type is refering to the hypervisor used for the domain, which is still 'kvm'. What is different here is just the userspace device model. If you look at the 3 different Xen user spaces we support, all of them use still. So just use here for kvmtool. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|