kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Daniel P. Berrange" <berrange@redhat.com>
To: Osier Yang <jyang@redhat.com>
Cc: libvir-list@redhat.com, kvm@vger.kernel.org,
	penberg@cs.helsinki.fi, levinsasha928@gmail.com,
	gorcunov@gmail.com, mingo@elte.hu, asias.hejun@gmail.com
Subject: Re: [libvirt] [PATCH 3/7] kvmtool: Add new enums and error codes for the driver
Date: Tue, 6 Dec 2011 14:47:51 +0000	[thread overview]
Message-ID: <20111206144751.GE7937@redhat.com> (raw)
In-Reply-To: <1321012626-31713-5-git-send-email-jyang@redhat.com>

On Fri, Nov 11, 2011 at 07:57:02PM +0800, Osier Yang wrote:
> ---
>  include/libvirt/virterror.h |    1 +
>  src/driver.h                |    1 +
>  src/util/virterror.c        |    3 +++
>  3 files changed, 5 insertions(+), 0 deletions(-)
> 
> diff --git a/include/libvirt/virterror.h b/include/libvirt/virterror.h
> index a8549b7..deda42d 100644
> --- a/include/libvirt/virterror.h
> +++ b/include/libvirt/virterror.h
> @@ -84,6 +84,7 @@ typedef enum {
>      VIR_FROM_LIBXL = 41,	/* Error from libxenlight driver */
>      VIR_FROM_LOCKING = 42,	/* Error from lock manager */
>      VIR_FROM_HYPERV = 43,	/* Error from Hyper-V driver */
> +    VIR_FROM_KVMTOOL = 44,	/* Error from kvm tool driver */
>  } virErrorDomain;
>  
>  
> diff --git a/src/driver.h b/src/driver.h
> index 4c14aaa..158a13c 100644
> --- a/src/driver.h
> +++ b/src/driver.h
> @@ -30,6 +30,7 @@ typedef enum {
>      VIR_DRV_VMWARE = 13,
>      VIR_DRV_LIBXL = 14,
>      VIR_DRV_HYPERV = 15,
> +    VIR_DRV_KVMTOOL = 16,
>  } virDrvNo;
>  
>  
> diff --git a/src/util/virterror.c b/src/util/virterror.c
> index 5006fa2..abb5b5a 100644
> --- a/src/util/virterror.c
> +++ b/src/util/virterror.c
> @@ -175,6 +175,9 @@ static const char *virErrorDomainName(virErrorDomain domain) {
>          case VIR_FROM_HYPERV:
>              dom = "Hyper-V ";
>              break;
> +        case VIR_FROM_KVMTOOL:
> +            dom = "KVMTOOL ";
> +            break;
>      }
>      return(dom);
>  }

Trivial, ACK

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|

  reply	other threads:[~2011-12-06 14:48 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-11 11:56 [libvirt] (no subject) Osier Yang
2011-11-11 11:30 ` [libvirt] Add driver support for Native Linux KVM Tool Osier Yang
2011-11-11 11:56 ` [libvirt] [PATCH 1/7] kvmtool: Add configure support Osier Yang
2011-11-11 11:57 ` [libvirt] [PATCH] kvm tools: Introduce an ENV variable for the state dir Osier Yang
2011-12-06 14:39   ` Daniel P. Berrange
2011-12-09  7:18     ` Osier Yang
2011-11-11 11:57 ` [libvirt] [PATCH 2/7] kvmtool: Add documents Osier Yang
2011-12-06 14:47   ` Daniel P. Berrange
2011-11-11 11:57 ` [libvirt] [PATCH 3/7] kvmtool: Add new enums and error codes for the driver Osier Yang
2011-12-06 14:47   ` Daniel P. Berrange [this message]
2011-11-11 11:57 ` [libvirt] [PATCH 4/7] kvmtool: Add hook support for kvmtool domain Osier Yang
2011-12-06 14:48   ` Daniel P. Berrange
2011-11-11 11:57 ` [libvirt] [PATCH 5/7] kvmtool: Add new domain type Osier Yang
2011-12-06 14:46   ` Daniel P. Berrange
2011-12-09  7:22     ` Osier Yang
2011-11-11 11:57 ` [libvirt] [PATCH 6/7] conf: Set source type of the stub console Osier Yang
2011-11-11 11:57 ` [libvirt] [PATCH 7/7] kvmtool: Implementation for kvm tool driver Osier Yang
2011-12-06 14:55   ` Daniel P. Berrange
2011-12-09  7:30     ` Osier Yang
2011-12-06 14:38 ` [libvirt] (no subject) Daniel P. Berrange
2011-12-07  6:21   ` Sasha Levin
2011-12-07  9:16     ` Daniel P. Berrange
2011-12-09 12:45       ` Osier Yang
2011-12-09 12:41     ` Osier Yang
2011-12-09 12:30   ` Osier Yang
2011-12-10 17:56     ` Pekka Enberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111206144751.GE7937@redhat.com \
    --to=berrange@redhat.com \
    --cc=asias.hejun@gmail.com \
    --cc=gorcunov@gmail.com \
    --cc=jyang@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=levinsasha928@gmail.com \
    --cc=libvir-list@redhat.com \
    --cc=mingo@elte.hu \
    --cc=penberg@cs.helsinki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).