From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Daniel P. Berrange" Subject: Re: [libvirt] [PATCH 4/7] kvmtool: Add hook support for kvmtool domain Date: Tue, 6 Dec 2011 14:48:51 +0000 Message-ID: <20111206144851.GF7937@redhat.com> References: <1321012626-31713-1-git-send-email-jyang@redhat.com> <1321012626-31713-6-git-send-email-jyang@redhat.com> Reply-To: "Daniel P. Berrange" Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Cc: libvir-list@redhat.com, kvm@vger.kernel.org, penberg@cs.helsinki.fi, levinsasha928@gmail.com, gorcunov@gmail.com, mingo@elte.hu, asias.hejun@gmail.com To: Osier Yang Return-path: Received: from mx1.redhat.com ([209.132.183.28]:4494 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752806Ab1LFOtf (ORCPT ); Tue, 6 Dec 2011 09:49:35 -0500 Content-Disposition: inline In-Reply-To: <1321012626-31713-6-git-send-email-jyang@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Fri, Nov 11, 2011 at 07:57:03PM +0800, Osier Yang wrote: > Just like QEMU and LXC, kvm driver intends to support running hook > script before domain starting and after domain shutdown too. > --- > src/util/hooks.c | 11 ++++++++++- > src/util/hooks.h | 8 ++++++++ > 2 files changed, 18 insertions(+), 1 deletions(-) > > diff --git a/src/util/hooks.c b/src/util/hooks.c > index 110a94b..765cb68 100644 > --- a/src/util/hooks.c > +++ b/src/util/hooks.c > @@ -52,12 +52,14 @@ VIR_ENUM_DECL(virHookDaemonOp) > VIR_ENUM_DECL(virHookSubop) > VIR_ENUM_DECL(virHookQemuOp) > VIR_ENUM_DECL(virHookLxcOp) > +VIR_ENUM_DECL(virHookKvmToolOp) > > VIR_ENUM_IMPL(virHookDriver, > VIR_HOOK_DRIVER_LAST, > "daemon", > "qemu", > - "lxc") > + "lxc", > + "kvmtool") > > VIR_ENUM_IMPL(virHookDaemonOp, VIR_HOOK_DAEMON_OP_LAST, > "start", > @@ -79,6 +81,10 @@ VIR_ENUM_IMPL(virHookLxcOp, VIR_HOOK_LXC_OP_LAST, > "start", > "stopped") > > +VIR_ENUM_IMPL(virHookKvmToolOp, VIR_HOOK_KVMTOOL_OP_LAST, > + "start", > + "stopped") > + > static int virHooksFound = -1; > > /** > @@ -230,6 +236,9 @@ virHookCall(int driver, const char *id, int op, int sub_op, const char *extra, > case VIR_HOOK_DRIVER_LXC: > opstr = virHookLxcOpTypeToString(op); > break; > + case VIR_HOOK_DRIVER_KVMTOOL: > + opstr = virHookKvmToolOpTypeToString(op); > + break; > } > if (opstr == NULL) { > virHookReportError(VIR_ERR_INTERNAL_ERROR, > diff --git a/src/util/hooks.h b/src/util/hooks.h > index fd7411c..69081c4 100644 > --- a/src/util/hooks.h > +++ b/src/util/hooks.h > @@ -31,6 +31,7 @@ enum virHookDriverType { > VIR_HOOK_DRIVER_DAEMON = 0, /* Daemon related events */ > VIR_HOOK_DRIVER_QEMU, /* QEmu domains related events */ > VIR_HOOK_DRIVER_LXC, /* LXC domains related events */ > + VIR_HOOK_DRIVER_KVMTOOL, /* KVMTOOL domains related events */ > > VIR_HOOK_DRIVER_LAST, > }; > @@ -67,6 +68,13 @@ enum virHookLxcOpType { > VIR_HOOK_LXC_OP_LAST, > }; > > +enum virHookKvmToolOpType { > + VIR_HOOK_KVMTOOL_OP_START, /* domain is about to start */ > + VIR_HOOK_KVMTOOL_OP_STOPPED, /* domain has stopped */ > + > + VIR_HOOK_KVMTOOL_OP_LAST, > +}; > + > int virHookInitialize(void); > > int virHookPresent(int driver); Trivial, ACK Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|