From mboxrd@z Thu Jan  1 00:00:00 1970
From: Cyrill Gorcunov <gorcunov@gmail.com>
Subject: Re: [PATCH 16/28] kvm tools: Allow load_flat_binary() to load an
 initrd alongside
Date: Wed, 7 Dec 2011 10:33:56 +0400
Message-ID: <20111207063356.GD20459@moon>
References: <cover.1323141075.git.matt@ozlabs.org>
 <4EDD8ED3.8010608@ozlabs.org>
 <CAOJsxLEVcPgD4mXUqd2A24q-JSqaR6PYbNovdGtTovc2+sjOYQ@mail.gmail.com>
 <20111206120438.GD29781@moon>
 <4EDEB673.8070303@ozlabs.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Pekka Enberg <penberg@kernel.org>, kvm@vger.kernel.org,
	kvm-ppc@vger.kernel.org, Asias He <asias.hejun@gmail.com>,
	Ingo Molnar <mingo@elte.hu>,
	Sasha Levin <levinsasha928@gmail.com>
To: Matt Evans <matt@ozlabs.org>
Return-path: <kvm-ppc-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <4EDEB673.8070303@ozlabs.org>
Sender: kvm-ppc-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org

On Wed, Dec 07, 2011 at 11:42:27AM +1100, Matt Evans wrote:
> Hi Cyrill,
> 
> On 06/12/11 23:04, Cyrill Gorcunov wrote:
> > On Tue, Dec 06, 2011 at 12:29:48PM +0200, Pekka Enberg wrote:
> > ...
> >>
> >> Otherwise looks OK to me. Cyrill?
> >>
> > 
> > It might be not seen from patch (or my local kvm repo
> > is not yet updated well) but I somehow miss who will be
> > reading initrd in case of loading flat image? If noone,
> > then what's the point to pass fd there at all?
> 
> I pass in the initrd fd in generic code in preparation for the PPC support in
> "[PATCH 1/8] kvm tools: Add initial SPAPR PPC64 architecture support" which uses
> it.  As you saw, I haven't made x86 load the initrd in the case of a flat kernel
> binary being loaded; I didn't think a flat kernel can have a non-embedded initrd
> on x86?  (My x86 is rusty, this may not be true ;) bootparams are [b]zImage
> only?)
> 

Ah, I see. Sorry for confusion. Thanks.

	Cyrill