From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH 05/28] kvm tools: 64-bit tidy; use PRIx64 when printf'ing
 u64s and link appropriately
Date: Thu, 8 Dec 2011 06:49:43 +0100
Message-ID: <20111208054943.GA13855@elte.hu>
References: <20111206082827.GA30062@elte.hu>
 <20111206100538.GA8178@bloggs.ozlabs.ibm.com>
 <20111206102428.GB15966@elte.hu>
 <4EDF0F60.8080301@ozlabs.org>
 <20111207081602.GA8023@elte.hu>
 <alpine.LFD.2.02.1112071914460.1646@tux.localdomain>
 <4EE02BB2.5090908@ozlabs.org>
 <20111208044944.GB9485@elte.hu>
 <4EE0437F.5060505@ozlabs.org>
 <4EE04F6C.6090100@ozlabs.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Pekka Enberg <penberg@kernel.org>,
	Paul Mackerras <paulus@samba.org>,
	Sasha Levin <levinsasha928@gmail.com>, kvm@vger.kernel.org,
	kvm-ppc@vger.kernel.org, Pekka Enberg <penberg@cs.helsinki.fi>
To: Matt Evans <matt@ozlabs.org>
Return-path: <kvm-ppc-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <4EE04F6C.6090100@ozlabs.org>
Sender: kvm-ppc-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org


* Matt Evans <matt@ozlabs.org> wrote:

> Since tools/kvm/include/linux/types.h only requires __u32, 
> __u64 et al from <asm/types.h>, wouldn't it be most 
> straightforward to just #include <asm-generic/int-ll64.h>?  
> This avoids #define __KERNEL__ breaking other includes brought 
> into userland, avoids changing system headers/distros, and 
> includes the file we're really interested in on both x86 & 
> PPC.

No system headers need to be changed: you can just patch 
powerpc/types.h with the extra __SANE_USERSPACE__ define (or any 
suitable name) and the KVM tool should work as-is.

The beauty of tools/kvm/ being integrated into the kernel tree.

Really, if that works and if the PowerPC folks agree then we 
have an immediate, fully adequate, instantly applicable 
solution.

Thanks,

	Ingo