From: David Gibson <david@gibson.dropbear.id.au>
To: Matt Evans <matt@ozlabs.org>
Cc: kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, penberg@kernel.org,
asias.hejun@gmail.com, levinsasha928@gmail.com,
gorcunov@gmail.com, aik@ozlabs.ru
Subject: Re: [PATCH V2 4/6] kvm tools: Add PPC64 XICS interrupt controller support
Date: Wed, 14 Dec 2011 13:35:55 +1100 [thread overview]
Message-ID: <20111214023555.GD21214@truffala.fritz.box> (raw)
In-Reply-To: <1323760250-13237-5-git-send-email-matt@ozlabs.org>
On Tue, Dec 13, 2011 at 06:10:48PM +1100, Matt Evans wrote:
> This patch adds XICS emulation code (heavily borrowed from QEMU), and wires
> this into kvm_cpu__irq() to fire a CPU IRQ via KVM. A device tree entry is
> also added. IPIs work, xics_alloc_irqnum() is added to allocate an external
> IRQ (which will later be used by the PHB PCI code) and finally, kvm__irq_line()
> can be called to raise an IRQ on XICS.\
Hrm, looks like you took a somewhat old version of xics.c from qemu.
It dangerously uses the same variable names for global irq numbers and
numbers local to one ics unit. It used to have at least one bug
caused by confusing the two, which I'm not sure if you've also copied.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
next prev parent reply other threads:[~2011-12-14 2:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-13 7:10 [PATCH V2 0/6] Add initial SPAPR PPC64 architecture support Matt Evans
2011-12-13 7:10 ` [PATCH V2 1/6] kvm tools: Generate SPAPR PPC64 guest device tree Matt Evans
2011-12-14 2:25 ` David Gibson
2011-12-13 7:10 ` [PATCH V2 2/6] kvm tools: Add SPAPR PPC64 hcall & rtascall structure Matt Evans
2011-12-14 2:32 ` David Gibson
2011-12-13 7:10 ` [PATCH V2 3/6] kvm tools: Add SPAPR PPC64 HV console Matt Evans
2011-12-13 7:10 ` [PATCH V2 4/6] kvm tools: Add PPC64 XICS interrupt controller support Matt Evans
2011-12-14 2:35 ` David Gibson [this message]
2011-12-20 1:16 ` Matt Evans
2011-12-21 0:39 ` David Gibson
2011-12-13 7:10 ` [PATCH V2 5/6] kvm tools: Add PPC64 PCI Host Bridge Matt Evans
2011-12-13 7:10 ` [PATCH V2 6/6] kvm tools: Add PPC64 kvm_cpu__emulate_io() Matt Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111214023555.GD21214@truffala.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=aik@ozlabs.ru \
--cc=asias.hejun@gmail.com \
--cc=gorcunov@gmail.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=levinsasha928@gmail.com \
--cc=matt@ozlabs.org \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).