From: Marcelo Tosatti <mtosatti@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: Eric B Munson <emunson@mgebm.net>,
mingo@redhat.com, hpa@zytor.com, arnd@arndb.de,
ryanh@linux.vnet.ibm.com, aliguori@us.ibm.com,
jeremy.fitzhardinge@citrix.com, levinsasha928@gmail.com,
Jan Kiszka <jan.kiszka@siemens.com>,
kvm@vger.kernel.org, linux-arch@vger.kernel.org, x86@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/5 V5] Avoid soft lockup message when KVM is stopped by host
Date: Mon, 19 Dec 2011 15:50:47 -0200 [thread overview]
Message-ID: <20111219175047.GA17347@amt.cnet> (raw)
In-Reply-To: <20111219161108.GA15848@amt.cnet>
On Mon, Dec 19, 2011 at 02:11:08PM -0200, Marcelo Tosatti wrote:
> On Mon, Dec 19, 2011 at 02:59:10PM +0200, Avi Kivity wrote:
> > On 12/16/2011 11:31 AM, Marcelo Tosatti wrote:
> > > > >
> > > > > Slow enough that progress of the watchdog thread is unable to keep up
> > > > > with timer interrupt processing. This is considered a hang and
> > > > > should be reported.
> > > >
> > > > It's not a guest hang though!
> > >
> > > No, but your host system is in such a load state that for the sake of
> > > system usability you better print out a warning message.
> >
> > What's the point in printing it in the guest? The guest can't observe
> > host conditions.
> >
> > > I don't see the advantage of preempt notifiers over the simple, paravirt
> > > solution proposed? Note kvmclock is already paravirt.
> >
> > Right.
> >
> > > What do you want to be done in preempt notifiers? Measure what to
> > > consider setting this flag?
> >
> > Preemption while TASK_RUNNING or TASK_UNINTERRUPTIBLE.
>
> Maybe it is good (not sure), need to look into schedstats and think of
> cases that would break legitimate guest hangs. And it probably also
> affects the position of clearing the flag on the guest side as its
> currently done in Eric's patchset.
Is the task going to be TASK_UNINTERRUPTIBLE with SIGSTOP? Don't think
so.
Note "Preemption while TASK_RUNNING or TASK_UNINTERRUPTIBLE" is not
functional for guest-paused-via-QEMU-monitor case.
next prev parent reply other threads:[~2011-12-19 20:44 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-05 20:18 [PATCH 0/5 V5] Avoid soft lockup message when KVM is stopped by host Eric B Munson
2011-12-05 20:19 ` [PATCH 1/5 V5] Add flag to indicate that a vm was stopped by the host Eric B Munson
2011-12-05 20:19 ` [PATCH 2/5 V5] Add functions to check if the host has stopped the vm Eric B Munson
2011-12-07 14:31 ` Avi Kivity
2011-12-08 15:23 ` Eric B Munson
2011-12-14 12:11 ` Marcelo Tosatti
2011-12-14 14:37 ` Avi Kivity
2011-12-14 17:11 ` Eric B Munson
2011-12-14 17:30 ` Avi Kivity
2011-12-14 17:57 ` Eric B Munson
2011-12-05 20:19 ` [PATCH 3/5 V5] Add ioctl for KVMCLOCK_GUEST_STOPPED Eric B Munson
2011-12-07 14:34 ` Avi Kivity
2011-12-08 15:25 ` Eric B Munson
2011-12-05 20:19 ` [PATCH 4/5 V5] Add generic stubs for kvm stop check functions Eric B Munson
2011-12-07 14:36 ` Avi Kivity
2011-12-08 15:27 ` Eric B Munson
2011-12-05 20:19 ` [PATCH 5/5 V5] Add check for suspended vm in softlockup detector Eric B Munson
2011-12-07 14:38 ` Avi Kivity
2011-12-07 14:41 ` [PATCH 0/5 V5] Avoid soft lockup message when KVM is stopped by host Avi Kivity
2011-12-08 15:19 ` Eric B Munson
2011-12-14 15:08 ` Avi Kivity
2011-12-14 17:58 ` Eric B Munson
2011-12-15 9:48 ` Avi Kivity
2011-12-15 18:53 ` Eric B Munson
2011-12-19 13:01 ` Avi Kivity
2011-12-11 12:40 ` Dor Laor
2011-12-14 12:18 ` Marcelo Tosatti
2011-12-14 12:16 ` Marcelo Tosatti
2011-12-14 14:39 ` Avi Kivity
2011-12-14 14:49 ` Anthony Liguori
2011-12-14 15:01 ` Avi Kivity
2011-12-14 14:54 ` Eric B Munson
2011-12-14 18:21 ` Marcelo Tosatti
2011-12-15 10:21 ` Avi Kivity
2011-12-16 9:31 ` Marcelo Tosatti
2011-12-19 12:59 ` Avi Kivity
2011-12-19 16:11 ` Marcelo Tosatti
2011-12-19 17:50 ` Marcelo Tosatti [this message]
2011-12-22 9:59 ` Avi Kivity
2011-12-08 11:34 ` Amit Shah
2011-12-15 11:55 ` Avi Kivity
2011-12-19 12:52 ` Amit Shah
2011-12-19 12:59 ` Avi Kivity
2011-12-19 17:59 ` Amit Shah
2011-12-22 9:18 ` Dor Laor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111219175047.GA17347@amt.cnet \
--to=mtosatti@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=arnd@arndb.de \
--cc=avi@redhat.com \
--cc=emunson@mgebm.net \
--cc=hpa@zytor.com \
--cc=jan.kiszka@siemens.com \
--cc=jeremy.fitzhardinge@citrix.com \
--cc=kvm@vger.kernel.org \
--cc=levinsasha928@gmail.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=ryanh@linux.vnet.ibm.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).