From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Mackerras Subject: Re: [PATCH 07/28] kvm tools: Move 'kvm__recommended_cpus' to arch-specific code Date: Thu, 22 Dec 2011 09:17:35 +1100 Message-ID: <20111221221734.GA29797@bloggs.ozlabs.ibm.com> References: <4EDD8E73.8040505@ozlabs.org> <1323159616.3882.7.camel@lappy> <4EDF04F4.40805@ozlabs.org> <1323239695.8489.25.camel@lappy> <4EDF138E.6040703@ozlabs.org> <4EDF158E.1050607@ozlabs.org> <1323246564.4009.2.camel@lappy> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Sasha Levin , Matt Evans , KVM list , kvm-ppc@vger.kernel.org To: Alexander Graf Return-path: Content-Disposition: inline In-Reply-To: Sender: kvm-ppc-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Tue, Dec 20, 2011 at 04:23:28PM +0100, Alexander Graf wrote: > > - vcpu = kzalloc(sizeof(struct kvm_vcpu), GFP_KERNEL); > > + vcpu = kmem_cache_zalloc(kvm_vcpu_cache, GFP_KERNEL); > > Paul, is there any rationale on why not to use the kmem cache? Are > we bound by real mode magic again? No, I just hadn't realized it existed. This looks fine to me. Acked-by: Paul Mackerras Paul.