From: "tj@kernel.org" <tj@kernel.org>
To: "Alex,Shi" <alex.shi@intel.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
Christoph Lameter <cl@gentwo.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"eric.dumazet@gmail.com" <eric.dumazet@gmail.com>,
"Huang, Ying" <ying.huang@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
"mingo@redhat.com" <mingo@redhat.com>,
"avi@redhat.com" <avi@redhat.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
David Miller <davem@davemloft.net>,
"kaber@trash.net" <kaber@trash.net>,
"a.p.zijlstra@chello.nl" <a.p.zijlstra@chello.nl>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 3/3] Code clean up for percpu_xxx() functions
Date: Wed, 11 Jan 2012 09:19:51 -0800 [thread overview]
Message-ID: <20120111171951.GF26832@google.com> (raw)
In-Reply-To: <1326272921.5695.263.camel@debian>
On Wed, Jan 11, 2012 at 05:08:41PM +0800, Alex,Shi wrote:
> On Mon, 2011-11-21 at 17:06 -0700, tj@kernel.org wrote:
> > (cc'ing hpa and quoting whole body)
> > >
> > > Signed-off-by: Alex Shi <alex.shi@intel.com>
> > > Acked-by: Christoph Lameter <cl@gentwo.org>
> >
> > Acked-by: Tejun Heo <tj@kernel.org>
> >
> > hpa, I suppose this should go through x86? The original patch can be
> > accessed at
> >
> > http://article.gmane.org/gmane.linux.kernel/1218055/raw
>
> Rend for 3.2 kernel, no any change needed to apply on latest Linus'
> tree. :)
>
> Actually, this clean up has no performance or security impact for
> kernel. On the contrary, removing some potential redundant preempt
> disable will bring a slight performance benefit to kernel.
>
> This 3rd patch depends on previous 2 patches, the 2nd one kvm code clean
> up was submitted for 3.3 kernel. but the 2st one net code clean up is
> waiting for David's comments.
Alex, can you please collect all patches into a single patchset?
Please split it such that, usage changes are per-system so that they
can be routed through respective subsystems (x86 or net) and updates
to percpu proper which can be applied after other changes have been
applied. It would probably be best to route these patches separately
rather than all through percpu as it touches a lot of different places
and is likely to cause conflicts. I *think* the best way would be,
* Submit per-subsystem patches and get them merged to subsystem trees.
* (Optional) Apply a patch to mark unused interface deprecated in
percpu tree, so that new usages in linux-next can be detected.
* Towards the end of the next merge window, merge a patch to actually
kill the old interface.
Thanks.
--
tejun
next prev parent reply other threads:[~2012-01-11 17:19 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1318237851.27949.190.camel@debian>
[not found] ` <alpine.DEB.2.00.1110101026080.16264@router.home>
[not found] ` <1318324774.27949.693.camel@debian>
[not found] ` <alpine.DEB.2.00.1110110910480.3388@router.home>
[not found] ` <1318382964.27949.782.camel@debian>
[not found] ` <1318428673.29699.13.camel@debian>
[not found] ` <alpine.DEB.2.00.1110120910540.26610@router.home>
[not found] ` <1318908091.23426.52.camel@debian>
[not found] ` <alpine.DEB.2.00.1110180932330.687@router.home>
2011-10-19 9:23 ` [PATCH] Code clean up for percpu_xxx() functions Alex,Shi
2011-10-19 9:26 ` Avi Kivity
2011-10-20 2:45 ` Alex,Shi
2011-10-20 7:34 ` [PATCH 2/3] kvm: use this_cpu_xxx replace percpu_xxx funcs Alex,Shi
2011-10-24 2:50 ` Alex,Shi
2011-10-24 11:05 ` Avi Kivity
2011-11-21 9:02 ` Alex,Shi
2011-11-21 9:20 ` Avi Kivity
2011-11-21 9:52 ` Alex,Shi
2012-01-11 8:48 ` Alex,Shi
2011-10-19 15:34 ` [PATCH] Code clean up for percpu_xxx() functions Christoph Lameter
2011-10-20 2:44 ` Alex,Shi
2011-10-20 5:08 ` Eric Dumazet
2011-10-20 6:04 ` Alex,Shi
2011-10-20 6:13 ` Alex,Shi
2011-10-20 6:04 ` Alex,Shi
2011-10-20 7:20 ` [PATCH 0/3] code clean and optimzed for percpu_xxx serials funcs Alex,Shi
2011-10-20 7:32 ` [PATCH 1/3] net: use this_cpu_xxx replace percpu_xxx funcs Alex,Shi
2011-10-20 8:38 ` Eric Dumazet
2011-11-21 9:00 ` Alex,Shi
2011-12-02 2:33 ` Alex,Shi
2011-12-02 11:56 ` Patrick McHardy
2012-01-11 8:45 ` Alex,Shi
2012-01-11 9:03 ` David Miller
2012-01-11 9:10 ` Alex,Shi
2011-10-20 7:35 ` [PATCH 3/3] Code clean up for percpu_xxx() functions Alex,Shi
2011-11-21 9:10 ` Alex,Shi
2011-11-22 0:06 ` tj
2012-01-11 9:08 ` Alex,Shi
2012-01-11 17:19 ` tj [this message]
2012-01-12 0:44 ` H. Peter Anvin
2012-01-12 2:05 ` Alex,Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120111171951.GF26832@google.com \
--to=tj@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=alex.shi@intel.com \
--cc=avi@redhat.com \
--cc=cl@gentwo.org \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=hpa@zytor.com \
--cc=kaber@trash.net \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).