From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [PATCH] pci-assign: Fix multifunction support Date: Wed, 18 Jan 2012 08:17:25 -0200 Message-ID: <20120118101725.GA23725@amt.cnet> References: <20120116171141.15543.17245.stgit@bling.home> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, jan.kiszka@siemens.com To: Alex Williamson Return-path: Received: from mx1.redhat.com ([209.132.183.28]:7021 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757510Ab2ARNwT (ORCPT ); Wed, 18 Jan 2012 08:52:19 -0500 Content-Disposition: inline In-Reply-To: <20120116171141.15543.17245.stgit@bling.home> Sender: kvm-owner@vger.kernel.org List-ID: On Mon, Jan 16, 2012 at 10:11:51AM -0700, Alex Williamson wrote: > The core PCI code sets the multifunction bit in the header before > calling the device initfn. For device assignment, we're blasting > that value with the actual hardware value, so nobody sees the > additional functions if the devices isn't physically multifunction. > Switch the HEADER_TYPE to a fully emulated field (all read-only > anyway) and add setting and clearing of the multifunction bit to > match qemu directive. > > Signed-off-by: Alex Williamson Applied, thanks.