From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joerg Roedel Subject: Re: [PATCH 1/3] KVM: x86 emulator: Fix task switch privilege checks Date: Wed, 25 Jan 2012 17:00:58 +0100 Message-ID: <20120125160058.GG19255@amd.com> References: <1327335048-31925-1-git-send-email-kwolf@redhat.com> <1327335048-31925-2-git-send-email-kwolf@redhat.com> <20120124140316.GD19255@amd.com> <4F1EBCF1.9050808@redhat.com> <20120124141630.GD9571@redhat.com> <4F1EBF32.6020904@redhat.com> <20120124162350.GD538@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Cc: Kevin Wolf , , , , To: Gleb Natapov Return-path: Received: from tx2ehsobe004.messaging.microsoft.com ([65.55.88.14]:26568 "EHLO TX2EHSOBE007.bigfish.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754749Ab2AYQBJ (ORCPT ); Wed, 25 Jan 2012 11:01:09 -0500 Content-Disposition: inline In-Reply-To: <20120124162350.GD538@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, Jan 24, 2012 at 06:23:50PM +0200, Gleb Natapov wrote: > On Tue, Jan 24, 2012 at 03:24:50PM +0100, Kevin Wolf wrote: > > However, task_switch_interception() itself does some more based on the > > value of reason, for example it decides whether or not to call > > skip_emulated_instruction(). > > > Joerg need to help us here. If intercept of task switch happens before > rip is advanced past instruction that cause it we have to know somehow > that task switch was caused by instruction. It is not enough that HW > checks permission, we still lack essential info. Hmm, the RIP in the VMCB points to the instruction causing the task switch. This is also true for lcall and ljmp. But in my experiments I have seen exit_int_info.valid = 1 for task-switches that went through the IDT. But I havn't tested the VM86 case, though. Kevin, can you please re-verify that exit_int_info.valid is always 0 in your experiment? On what hardware have you tested this? Thanks, Joerg -- AMD Operating System Research Center Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach General Managers: Alberto Bozzo Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632