From: Gleb Natapov <gleb@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: kvm@vger.kernel.org, joerg.roedel@amd.com,
yoshikawa.takuya@oss.ntt.co.jp, avi@redhat.com,
mtosatti@redhat.com
Subject: Re: [PATCH v2 0/3] Fix task switches into/out of VM86
Date: Fri, 27 Jan 2012 21:52:39 +0200 [thread overview]
Message-ID: <20120127195239.GB2938@redhat.com> (raw)
In-Reply-To: <1327692216-20450-1-git-send-email-kwolf@redhat.com>
On Fri, Jan 27, 2012 at 08:23:33PM +0100, Kevin Wolf wrote:
> I believe this should work with both VMX and SVM now. Gleb, Jörg, can one of
> you test this with SVM? I did some testing on my buggy processor and it looks
> as good as it gets, but it would be better if you could confirm.
>
You forgot to set cpl to 3 in vmcb in svm_set_rflags() when vm86 is enabled, no?
> Kevin Wolf (3):
> KVM: x86 emulator: Fix task switch privilege checks
> KVM: x86 emulator: VM86 segments must have DPL 3
> KVM: x86 emulator: Allow PM/VM86 switch during task switch
>
> arch/x86/include/asm/kvm_emulate.h | 3 +-
> arch/x86/include/asm/kvm_host.h | 4 +-
> arch/x86/kvm/emulate.c | 79 ++++++++++++++++++++++++++++++++---
> arch/x86/kvm/svm.c | 5 ++-
> arch/x86/kvm/vmx.c | 8 ++-
> arch/x86/kvm/x86.c | 12 ++++-
> 6 files changed, 94 insertions(+), 17 deletions(-)
>
> --
> 1.7.6.5
--
Gleb.
next prev parent reply other threads:[~2012-01-27 19:52 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-27 19:23 [PATCH v2 0/3] Fix task switches into/out of VM86 Kevin Wolf
2012-01-27 19:23 ` [PATCH v2 1/3] KVM: x86 emulator: Fix task switch privilege checks Kevin Wolf
2012-01-30 10:39 ` Avi Kivity
2012-01-30 11:12 ` Kevin Wolf
2012-01-27 19:23 ` [PATCH v2 2/3] KVM: x86 emulator: VM86 segments must have DPL 3 Kevin Wolf
2012-01-27 19:23 ` [PATCH v2 3/3] KVM: x86 emulator: Allow PM/VM86 switch during task switch Kevin Wolf
2012-01-30 10:24 ` Avi Kivity
2012-01-30 10:56 ` Gleb Natapov
2012-01-30 12:02 ` Avi Kivity
2012-01-30 12:04 ` Gleb Natapov
2012-01-30 13:24 ` Avi Kivity
2012-01-30 11:05 ` Kevin Wolf
2012-01-30 11:09 ` Gleb Natapov
2012-01-30 13:23 ` Avi Kivity
2012-01-30 14:01 ` Kevin Wolf
2012-01-30 14:32 ` Avi Kivity
2012-01-30 15:26 ` Kevin Wolf
2012-01-30 15:44 ` Avi Kivity
2012-01-30 15:55 ` Takuya Yoshikawa
2012-01-31 9:37 ` Gleb Natapov
2012-01-31 10:26 ` Avi Kivity
2012-01-27 19:52 ` Gleb Natapov [this message]
2012-01-30 8:48 ` [PATCH v2 0/3] Fix task switches into/out of VM86 Kevin Wolf
2012-01-30 8:55 ` Gleb Natapov
2012-01-30 10:22 ` Gleb Natapov
2012-01-30 10:35 ` Kevin Wolf
2012-01-30 10:45 ` Avi Kivity
2012-01-30 10:50 ` Gleb Natapov
2012-01-30 11:59 ` Avi Kivity
2012-01-30 12:16 ` Gleb Natapov
2012-01-30 13:27 ` Avi Kivity
2012-01-30 12:31 ` Gleb Natapov
2012-01-30 13:28 ` Avi Kivity
2012-01-30 13:29 ` Gleb Natapov
2012-01-30 13:39 ` Avi Kivity
2012-01-30 10:47 ` Gleb Natapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120127195239.GB2938@redhat.com \
--to=gleb@redhat.com \
--cc=avi@redhat.com \
--cc=joerg.roedel@amd.com \
--cc=kvm@vger.kernel.org \
--cc=kwolf@redhat.com \
--cc=mtosatti@redhat.com \
--cc=yoshikawa.takuya@oss.ntt.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).