From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gleb Natapov Subject: Re: [PATCH v2 0/3] Fix task switches into/out of VM86 Date: Fri, 27 Jan 2012 21:52:39 +0200 Message-ID: <20120127195239.GB2938@redhat.com> References: <1327692216-20450-1-git-send-email-kwolf@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: kvm@vger.kernel.org, joerg.roedel@amd.com, yoshikawa.takuya@oss.ntt.co.jp, avi@redhat.com, mtosatti@redhat.com To: Kevin Wolf Return-path: Received: from mx1.redhat.com ([209.132.183.28]:2644 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751609Ab2A0Two convert rfc822-to-8bit (ORCPT ); Fri, 27 Jan 2012 14:52:44 -0500 Content-Disposition: inline In-Reply-To: <1327692216-20450-1-git-send-email-kwolf@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Fri, Jan 27, 2012 at 08:23:33PM +0100, Kevin Wolf wrote: > I believe this should work with both VMX and SVM now. Gleb, J=C3=B6rg= , can one of > you test this with SVM? I did some testing on my buggy processor and = it looks > as good as it gets, but it would be better if you could confirm. >=20 You forgot to set cpl to 3 in vmcb in svm_set_rflags() when vm86 is ena= bled, no? > Kevin Wolf (3): > KVM: x86 emulator: Fix task switch privilege checks > KVM: x86 emulator: VM86 segments must have DPL 3 > KVM: x86 emulator: Allow PM/VM86 switch during task switch >=20 > arch/x86/include/asm/kvm_emulate.h | 3 +- > arch/x86/include/asm/kvm_host.h | 4 +- > arch/x86/kvm/emulate.c | 79 ++++++++++++++++++++++++++= ++++++--- > arch/x86/kvm/svm.c | 5 ++- > arch/x86/kvm/vmx.c | 8 ++- > arch/x86/kvm/x86.c | 12 ++++- > 6 files changed, 94 insertions(+), 17 deletions(-) >=20 > --=20 > 1.7.6.5 -- Gleb.