From: Alex Williamson <alex.williamson@redhat.com>
To: kvm@vger.kernel.org
Cc: alex.williamson@redhat.com, jan.kiszka@siemens.com,
shashidhar.patil@gmail.com
Subject: [PATCH 1/9] pci-assign: Optionally enable 64bit BARs in guest
Date: Sat, 28 Jan 2012 07:21:39 -0700 [thread overview]
Message-ID: <20120128142139.25681.19080.stgit@bling.home> (raw)
In-Reply-To: <20120128142104.25681.93072.stgit@bling.home>
To date we've only exposed BARs as 32bit even if the device
physically supports 64bit BARs. Enable 64bit BARs to be
exposed as such in the guest, which may free up MMIO below
4G should the guest choose to use it.
This adds a new mem64= option to pci-assign, with the
default being off for testing and enablement. The goal
is to eventually make this enabled by default.
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
---
hw/device-assignment.c | 13 +++++++++++--
hw/device-assignment.h | 2 ++
2 files changed, 13 insertions(+), 2 deletions(-)
diff --git a/hw/device-assignment.c b/hw/device-assignment.c
index 7f4a5ec..07ae0a0 100644
--- a/hw/device-assignment.c
+++ b/hw/device-assignment.c
@@ -49,6 +49,7 @@
#define IORESOURCE_IRQ 0x00000400
#define IORESOURCE_DMA 0x00000800
#define IORESOURCE_PREFETCH 0x00002000 /* No side effects */
+#define IORESOURCE_MEM_64 0x00100000
/* #define DEVICE_ASSIGNMENT_DEBUG 1 */
@@ -377,6 +378,11 @@ static int assigned_dev_register_regions(PCIRegion *io_regions,
? PCI_BASE_ADDRESS_MEM_PREFETCH
: PCI_BASE_ADDRESS_SPACE_MEMORY;
+ if ((pci_dev->features & ASSIGNED_DEVICE_USE_MEM64_MASK) &&
+ (cur_region->type & IORESOURCE_MEM_64)) {
+ t |= PCI_BASE_ADDRESS_MEM_TYPE_64;
+ }
+
/* map physical memory */
pci_dev->v_addrs[i].u.r_virtbase = mmap(NULL, cur_region->size,
PROT_WRITE | PROT_READ,
@@ -569,8 +575,9 @@ again:
rp->valid = 0;
rp->resource_fd = -1;
size = end - start + 1;
- flags &= IORESOURCE_IO | IORESOURCE_MEM | IORESOURCE_PREFETCH;
- if (size == 0 || (flags & ~IORESOURCE_PREFETCH) == 0)
+ flags &= IORESOURCE_IO | IORESOURCE_MEM |
+ IORESOURCE_PREFETCH | IORESOURCE_MEM_64;
+ if (size == 0 || !(flags & (IORESOURCE_IO | IORESOURCE_MEM)))
continue;
if (flags & IORESOURCE_MEM) {
flags &= ~IORESOURCE_IO;
@@ -1701,6 +1708,8 @@ static PCIDeviceInfo assign_info = {
ASSIGNED_DEVICE_USE_IOMMU_BIT, true),
DEFINE_PROP_BIT("prefer_msi", AssignedDevice, features,
ASSIGNED_DEVICE_PREFER_MSI_BIT, true),
+ DEFINE_PROP_BIT("mem64", AssignedDevice, features,
+ ASSIGNED_DEVICE_USE_MEM64_BIT, false),
DEFINE_PROP_INT32("bootindex", AssignedDevice, bootindex, -1),
DEFINE_PROP_STRING("configfd", AssignedDevice, configfd_name),
DEFINE_PROP_END_OF_LIST(),
diff --git a/hw/device-assignment.h b/hw/device-assignment.h
index 1b4aecc..8ee2274 100644
--- a/hw/device-assignment.h
+++ b/hw/device-assignment.h
@@ -76,9 +76,11 @@ typedef struct {
#define ASSIGNED_DEVICE_USE_IOMMU_BIT 0
#define ASSIGNED_DEVICE_PREFER_MSI_BIT 1
+#define ASSIGNED_DEVICE_USE_MEM64_BIT 2
#define ASSIGNED_DEVICE_USE_IOMMU_MASK (1 << ASSIGNED_DEVICE_USE_IOMMU_BIT)
#define ASSIGNED_DEVICE_PREFER_MSI_MASK (1 << ASSIGNED_DEVICE_PREFER_MSI_BIT)
+#define ASSIGNED_DEVICE_USE_MEM64_MASK (1 << ASSIGNED_DEVICE_USE_MEM64_BIT)
typedef struct AssignedDevice {
PCIDevice dev;
next prev parent reply other threads:[~2012-01-28 14:21 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-28 14:21 [PATCH 0/9] pci-assign: 64bit MMIO + better MSI-X table support Alex Williamson
2012-01-28 14:21 ` Alex Williamson [this message]
2012-01-31 12:40 ` [PATCH 1/9] pci-assign: Optionally enable 64bit BARs in guest Avi Kivity
2012-01-31 12:45 ` Jan Kiszka
2012-01-31 12:51 ` Avi Kivity
2012-01-31 12:57 ` Jan Kiszka
2012-01-31 13:10 ` Avi Kivity
2012-01-31 13:21 ` Jan Kiszka
2012-01-31 13:33 ` Avi Kivity
2012-01-31 21:08 ` Alex Williamson
2012-01-31 21:14 ` Michael S. Tsirkin
2012-02-01 9:03 ` Avi Kivity
2012-02-01 10:03 ` Michael S. Tsirkin
2012-02-01 13:55 ` Alex Williamson
2012-02-01 15:18 ` Michael S. Tsirkin
2012-02-01 15:24 ` Alex Williamson
2012-01-28 14:21 ` [PATCH 2/9] pci-assign: Fix warnings with DEBUG enabled Alex Williamson
2012-01-28 14:21 ` [PATCH 3/9] pci-assign: Update MSI-X MMIO to Memory API Alex Williamson
2012-01-31 12:45 ` Avi Kivity
2012-01-31 21:13 ` Alex Williamson
2012-02-01 4:22 ` Alex Williamson
2012-02-01 9:04 ` Avi Kivity
2012-02-01 13:56 ` Alex Williamson
2012-01-28 14:21 ` [PATCH 4/9] pci-assign: Use struct for MSI-X table Alex Williamson
2012-01-31 17:40 ` Michael S. Tsirkin
2012-01-31 19:05 ` Alex Williamson
2012-01-31 20:00 ` Michael S. Tsirkin
2012-01-31 21:17 ` Alex Williamson
2012-01-31 21:24 ` Michael S. Tsirkin
2012-01-31 21:30 ` Alex Williamson
2012-01-28 14:22 ` [PATCH 5/9] pci-assign: Only calculate maximum MSI-X vector entries once Alex Williamson
2012-01-31 20:18 ` Michael S. Tsirkin
2012-01-31 20:31 ` Alex Williamson
2012-01-31 20:56 ` Michael S. Tsirkin
2012-01-28 14:22 ` [PATCH 6/9] pci-assign: Proper initialization for MSI-X table Alex Williamson
2012-01-31 17:40 ` Michael S. Tsirkin
2012-01-31 19:07 ` Alex Williamson
2012-01-31 19:12 ` Michael S. Tsirkin
2012-01-31 19:16 ` Jan Kiszka
2012-01-31 20:19 ` Michael S. Tsirkin
2012-01-31 21:06 ` Alex Williamson
2012-01-28 14:22 ` [PATCH 7/9] pci-assign: Allocate entries for all MSI-X vectors Alex Williamson
2012-01-28 14:22 ` [PATCH 8/9] pci-assign: Use MSIX_PAGE_SIZE Alex Williamson
2012-01-28 14:22 ` [PATCH 9/9] pci-assign: Update MSI-X config based on table writes Alex Williamson
2012-01-31 12:50 ` Avi Kivity
2012-01-30 10:11 ` [PATCH 0/9] pci-assign: 64bit MMIO + better MSI-X table support Jan Kiszka
2012-01-30 13:44 ` Alex Williamson
2012-01-31 12:52 ` Avi Kivity
2012-01-31 12:56 ` Jan Kiszka
2012-02-06 15:55 ` Shashidhar Patil
2012-02-06 17:29 ` Alex Williamson
2012-02-09 16:23 ` Shashidhar Patil
2012-02-09 17:23 ` Alex Williamson
2012-02-12 16:30 ` Shashidhar Patil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120128142139.25681.19080.stgit@bling.home \
--to=alex.williamson@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=shashidhar.patil@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).