From: Takuya Yoshikawa <takuya.yoshikawa@gmail.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Avi Kivity <avi@redhat.com>,
kvm@vger.kernel.org, gleb@redhat.com, joerg.roedel@amd.com,
yoshikawa.takuya@oss.ntt.co.jp, mtosatti@redhat.com
Subject: Re: [PATCH v2 3/3] KVM: x86 emulator: Allow PM/VM86 switch during task switch
Date: Tue, 31 Jan 2012 00:55:40 +0900 [thread overview]
Message-ID: <20120131005540.4a44aaadd94794707b122134@gmail.com> (raw)
In-Reply-To: <4F26B68E.3030100@redhat.com>
On Mon, 30 Jan 2012 16:26:06 +0100
Kevin Wolf <kwolf@redhat.com> wrote:
> > The other case is what we're looking at, task switch. To actually
> > update cpl, set_segment() needs to look at cr0.pe and eflags, but these
> > might not have been committed yet. It's all solvable but the solution
> > involves knowing exactly what kvm and the emulator depend on, which
> > makes it very fragile. I think giving the emulator less complicated
> > primitives will make it more readable.
>
> I think the main problem here is that you have two sets of registers,
> one in the vcpu struct and one in the emulator context.
>
I think we can, partly?, eliminate the usage of the latter by moving the
register initialization to the decode/emulation stage, as once talked on
kvm ml, and changing the writeback code to use callbacks.
But still some refactoring is needed before that.
Takuya
next prev parent reply other threads:[~2012-01-30 15:55 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-27 19:23 [PATCH v2 0/3] Fix task switches into/out of VM86 Kevin Wolf
2012-01-27 19:23 ` [PATCH v2 1/3] KVM: x86 emulator: Fix task switch privilege checks Kevin Wolf
2012-01-30 10:39 ` Avi Kivity
2012-01-30 11:12 ` Kevin Wolf
2012-01-27 19:23 ` [PATCH v2 2/3] KVM: x86 emulator: VM86 segments must have DPL 3 Kevin Wolf
2012-01-27 19:23 ` [PATCH v2 3/3] KVM: x86 emulator: Allow PM/VM86 switch during task switch Kevin Wolf
2012-01-30 10:24 ` Avi Kivity
2012-01-30 10:56 ` Gleb Natapov
2012-01-30 12:02 ` Avi Kivity
2012-01-30 12:04 ` Gleb Natapov
2012-01-30 13:24 ` Avi Kivity
2012-01-30 11:05 ` Kevin Wolf
2012-01-30 11:09 ` Gleb Natapov
2012-01-30 13:23 ` Avi Kivity
2012-01-30 14:01 ` Kevin Wolf
2012-01-30 14:32 ` Avi Kivity
2012-01-30 15:26 ` Kevin Wolf
2012-01-30 15:44 ` Avi Kivity
2012-01-30 15:55 ` Takuya Yoshikawa [this message]
2012-01-31 9:37 ` Gleb Natapov
2012-01-31 10:26 ` Avi Kivity
2012-01-27 19:52 ` [PATCH v2 0/3] Fix task switches into/out of VM86 Gleb Natapov
2012-01-30 8:48 ` Kevin Wolf
2012-01-30 8:55 ` Gleb Natapov
2012-01-30 10:22 ` Gleb Natapov
2012-01-30 10:35 ` Kevin Wolf
2012-01-30 10:45 ` Avi Kivity
2012-01-30 10:50 ` Gleb Natapov
2012-01-30 11:59 ` Avi Kivity
2012-01-30 12:16 ` Gleb Natapov
2012-01-30 13:27 ` Avi Kivity
2012-01-30 12:31 ` Gleb Natapov
2012-01-30 13:28 ` Avi Kivity
2012-01-30 13:29 ` Gleb Natapov
2012-01-30 13:39 ` Avi Kivity
2012-01-30 10:47 ` Gleb Natapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120131005540.4a44aaadd94794707b122134@gmail.com \
--to=takuya.yoshikawa@gmail.com \
--cc=avi@redhat.com \
--cc=gleb@redhat.com \
--cc=joerg.roedel@amd.com \
--cc=kvm@vger.kernel.org \
--cc=kwolf@redhat.com \
--cc=mtosatti@redhat.com \
--cc=yoshikawa.takuya@oss.ntt.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).