From: Cyrill Gorcunov <gorcunov@openvz.org>
To: Pekka Enberg <penberg@kernel.org>
Cc: Sasha Levin <levinsasha928@gmail.com>,
Asias He <asias.hejun@gmail.com>, Ingo Molnar <mingo@elte.hu>,
KVM-ML <kvm@vger.kernel.org>
Subject: Re: [PATCH] kvm tool: Make kvm structure to carry name copy
Date: Sat, 4 Feb 2012 16:20:05 +0400 [thread overview]
Message-ID: <20120204122005.GA14818@moon> (raw)
In-Reply-To: <alpine.LFD.2.02.1202041414350.1778@tux.localdomain>
On Sat, Feb 04, 2012 at 02:15:36PM +0200, Pekka Enberg wrote:
> On Fri, 3 Feb 2012, Cyrill Gorcunov wrote:
> >If guest name is used (which is default case) the kvm might end
> >up carrying the pointer to name which is allocated on stack.
> >
> >kvm_cmd_run_init
> > (on stack) default_name
> > kvm__init(..., default_name)
> > kvm->name = default_name
> >
> >So I think better to allow kvm to carry own copy
> >of guest name. 64 symbols should be more than enough.
> >
> >Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
> >---
> >
> >I hope I didn't miss anything?
>
> Can't we just use strdup()?
>
Yeah, I think this will be even better, I'll update.
Cyrill
next prev parent reply other threads:[~2012-02-04 12:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-03 19:57 [PATCH] kvm tool: Make kvm structure to carry name copy Cyrill Gorcunov
2012-02-04 12:15 ` Pekka Enberg
2012-02-04 12:20 ` Cyrill Gorcunov [this message]
2012-02-04 12:26 ` Cyrill Gorcunov
2012-02-04 12:57 ` Pekka Enberg
2012-02-04 13:08 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120204122005.GA14818@moon \
--to=gorcunov@openvz.org \
--cc=asias.hejun@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=levinsasha928@gmail.com \
--cc=mingo@elte.hu \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox