From mboxrd@z Thu Jan  1 00:00:00 1970
From: Gleb Natapov <gleb@redhat.com>
Subject: Re: [PATCH v3 3/4] KVM: SVM: Fix CPL updates
Date: Sun, 5 Feb 2012 13:16:17 +0200
Message-ID: <20120205111617.GT23536@redhat.com>
References: <1328293765-13663-1-git-send-email-kwolf@redhat.com>
 <1328293765-13663-4-git-send-email-kwolf@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: kvm@vger.kernel.org, joerg.roedel@amd.com,
	yoshikawa.takuya@oss.ntt.co.jp, avi@redhat.com, mtosatti@redhat.com
To: Kevin Wolf <kwolf@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:20349 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754963Ab2BELQX (ORCPT <rfc822;kvm@vger.kernel.org>);
	Sun, 5 Feb 2012 06:16:23 -0500
Content-Disposition: inline
In-Reply-To: <1328293765-13663-4-git-send-email-kwolf@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Fri, Feb 03, 2012 at 07:29:24PM +0100, Kevin Wolf wrote:
> Keep CPL at 0 in real mode and at 3 in VM86. In protected/long mode, use
> RPL rather than DPL of the code segment.
> 
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>  arch/x86/kvm/svm.c |   19 ++++++++++++++++---
>  1 files changed, 16 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c
> index 6a977c1..4124a7e 100644
> --- a/arch/x86/kvm/svm.c
> +++ b/arch/x86/kvm/svm.c
> @@ -1263,6 +1263,21 @@ static void svm_vcpu_put(struct kvm_vcpu *vcpu)
>  		wrmsrl(host_save_user_msrs[i], svm->host_user_msrs[i]);
>  }
>  
> +static void svm_update_cpl(struct kvm_vcpu *vcpu)
> +{
> +	struct vcpu_svm *svm = to_svm(vcpu);
> +	int cpl;
> +
> +	if (!is_protmode(vcpu))
> +		cpl = 0;
> +	else if (svm->vmcb->save.rflags & X86_EFLAGS_VM)
> +		cpl = 3;
> +	else
> +		cpl = svm->vmcb->save.cs.selector & 0x3;
> +
> +	svm->vmcb->save.cpl = cpl;
> +}
> +
As you probably know already I think cpl should be updated in
svm_get_rflags() too. With current patch restoring CS segment
register before rflags register after migration may cause cpl
to get wrong value for instance.

>  static unsigned long svm_get_rflags(struct kvm_vcpu *vcpu)
>  {
>  	return to_svm(vcpu)->vmcb->save.rflags;
> @@ -1538,9 +1553,7 @@ static void svm_set_segment(struct kvm_vcpu *vcpu,
>  		s->attrib |= (var->g & 1) << SVM_SELECTOR_G_SHIFT;
>  	}
>  	if (seg == VCPU_SREG_CS)
> -		svm->vmcb->save.cpl
> -			= (svm->vmcb->save.cs.attrib
> -			   >> SVM_SELECTOR_DPL_SHIFT) & 3;
> +		svm_update_cpl(vcpu);
>  
>  	mark_dirty(svm->vmcb, VMCB_SEG);
>  }
> -- 
> 1.7.6.5

--
			Gleb.