From: Joerg Roedel <joerg.roedel@amd.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: <kvm@vger.kernel.org>, <zamsden@gmail.com>
Subject: Re: [patch 1/8] Infrastructure for software and hardware based TSC rate scaling
Date: Wed, 8 Feb 2012 15:28:15 +0100 [thread overview]
Message-ID: <20120208142815.GB22598@amd.com> (raw)
In-Reply-To: <20120203174448.911929069@amt.cnet>
On Fri, Feb 03, 2012 at 03:43:50PM -0200, Marcelo Tosatti wrote:
> + if (user_tsc_khz > tsc_khz) {
> + vcpu->arch.tsc_catchup = 1;
> + vcpu->arch.tsc_always_catchup = 1;
> + } else
> + WARN(1, "user requested TSC rate below hardware speed\n");
> return;
[...]
> + if (user_tsc_khz > tsc_khz) {
> + vcpu->arch.tsc_catchup = 1;
> + vcpu->arch.tsc_always_catchup = 1;
> + } else
> + WARN(1, "user requested TSC rate below hardware speed\n");
Is it a good idea to have a user-triggerable WARN?
Joerg
--
AMD Operating System Research Center
Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632
next prev parent reply other threads:[~2012-02-08 14:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-03 17:43 [patch 0/8] KVM: Remaining body of TSC emulation work (Zachary Amsden) Marcelo Tosatti
2012-02-03 17:43 ` [patch 1/8] Infrastructure for software and hardware based TSC rate scaling Marcelo Tosatti
2012-02-08 14:28 ` Joerg Roedel [this message]
2012-02-03 17:43 ` [patch 2/8] Improve TSC offset matching Marcelo Tosatti
2012-02-03 17:43 ` [patch 3/8] Leave TSC synchronization window open with each new sync Marcelo Tosatti
2012-02-03 17:43 ` [patch 4/8] Fix last_guest_tsc / tsc_offset semantics Marcelo Tosatti
2012-02-03 17:43 ` [patch 5/8] Add last_host_tsc tracking back to KVM Marcelo Tosatti
2012-02-03 17:43 ` [patch 6/8] Allow adjust_tsc_offset to be in host or guest cycles Marcelo Tosatti
2012-02-03 17:43 ` [patch 7/8] Dont mark TSC unstable due to S4 suspend Marcelo Tosatti
2012-02-08 15:18 ` Joerg Roedel
2012-02-08 15:56 ` Marcelo Tosatti
2012-02-09 14:28 ` Joerg Roedel
2012-02-03 17:43 ` [patch 8/8] Track TSC synchronization in generations Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120208142815.GB22598@amd.com \
--to=joerg.roedel@amd.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=zamsden@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox